-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use do_not_edit variable in configure script #12610
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not use hardcoded string to warn users about file was generated by configure script. Since we already have do_not_edit variable we can use it
gibfahn
approved these changes
Apr 23, 2017
addaleax
approved these changes
Apr 23, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no issue for this. Is it ok?
This is perfectly fine. :)
CI: https://ci.nodejs.org/job/node-test-commit/9362/ EDIT: CI is green |
cjihrig
approved these changes
Apr 23, 2017
richardlau
approved these changes
Apr 23, 2017
jasnell
approved these changes
Apr 24, 2017
Thanks, landed in 78e0063! |
addaleax
pushed a commit
that referenced
this pull request
Apr 27, 2017
We should not use hardcoded string to warn users about file was generated by configure script. Since we already have do_not_edit variable we can use it PR-URL: #12610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
We should not use hardcoded string to warn users about file was generated by configure script. Since we already have do_not_edit variable we can use it PR-URL: #12610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
We should not use hardcoded string to warn users about file was generated by configure script. Since we already have do_not_edit variable we can use it PR-URL: #12610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
We should not use hardcoded string to warn users about file was generated by configure script. Since we already have do_not_edit variable we can use it PR-URL: #12610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
May 15, 2017
We should not use hardcoded string to warn users about file was generated by configure script. Since we already have do_not_edit variable we can use it PR-URL: #12610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
We should not use hardcoded string to warn users about file was generated by configure script. Since we already have do_not_edit variable we can use it PR-URL: nodejs/node#12610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
This is tiny-tiny change just to make our
configure
script a little bit better.Since in our
configure
script we already havedo_not_edit
variable we can use it in allplaces where we actually can. Probably the one place was missed and this PR should fix it.
P.S.
There is no issue for this. Is it ok? Should I create such issue first?
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build