Commits on May 30, 2017

1. src: add --use-bundled-ca --use-openssl-ca check …

   The --use-bundled-ca and --use-openssl-ca command line arguments are
   mutually exclusive but can both be used on the same command line.
   
   This commit adds a check if both options are used.
   
   Fixes: nodejs#12083
   PR-URL: nodejs#12087
   Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
   Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
   Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
   Reviewed-By: Richard Lau <riclau@uk.ibm.com>
   Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

   

   danbev committed May 30, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 2d4775a
   • Browse repository at this point

   Copy the full SHA

   2d4775a View commit details

   Browse the repository at this point in the history

2. src: guard bundled_ca/openssl_ca with HAVE_OPENSSL …

   Currently, the following warning will be reported when configuring
   without-ssl:
   
   ../src/node.cc:3653:8: warning: unused variable 'use_bundled_ca'
   [-Wunused-variable]
     bool use_bundled_ca = false;
          ^
   ../src/node.cc:3654:8: warning: unused variable 'use_openssl_ca'
   [-Wunused-variable]
     bool use_openssl_ca = false;
          ^
   
   I missed this when working on
   commit 8a7db9d ("src: add
   --use-bundled-ca --use-openssl-ca check").
   
   Refs: nodejs#12087
   PR-URL: nodejs#12302
   Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
   Reviewed-By: Richard Lau <riclau@uk.ibm.com>
   Reviewed-By: Anna Henningsen <anna@addaleax.net>

   

   danbev committed May 30, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 063fd18
   • Browse repository at this point

   Copy the full SHA

   063fd18 View commit details

   Browse the repository at this point in the history