Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https: make opts optional & immutable when create #13599

Closed
wants to merge 8 commits into from
Closed

https: make opts optional & immutable when create #13599

wants to merge 8 commits into from

Commits on Jun 10, 2017

  1. https: make opts optional & immutable when create 

    `opts` in `createServer` will be immutable that won't change origional
opts value. What's more, it's optional which can make `requestListener`
be the first argument.

Refs: nodejs#13584
    @XadillaX
    XadillaX committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    26d4efb View commit details
    Browse the repository at this point in the history

  2. use Object.assign to instead of util._extend

    @XadillaX
    XadillaX committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    2c7ff7b View commit details
    Browse the repository at this point in the history

  3. use the default message in common.mustNotCall

    @XadillaX
    XadillaX committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    b3a1ac6 View commit details
    Browse the repository at this point in the history

  4. update after reviewing

    @XadillaX
    XadillaX committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    9414765 View commit details
    Browse the repository at this point in the history

  5. add test case for no argument

    @XadillaX
    XadillaX committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    c798af8 View commit details
    Browse the repository at this point in the history

  6. use blocks to instead of server1, server2, ...

    @XadillaX
    XadillaX committed Jun 10, 2017
    Configuration menu
    Copy the full SHA
    5de8cf2 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2017

  1. add test skip

    @XadillaX
    XadillaX committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    dc2291c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2017

  1. delete default param to prevent some breaking changes

    @XadillaX
    XadillaX committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    2232fad View commit details
    Browse the repository at this point in the history