Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
process: fix error message of hrtime() #13739
Affected core subsystem(s)
I briefly discussed this with @addaleax. We assume that
To be honest, most error messages of this type are relatively useless without the stack as we never include the function name in the message itself. We could add an argument to
As always, needs to be approved by @nodejs/ctc.
process.hrtime() incorrectly passed the function name to errors.TypeError instead of the name of the argument. Additionally, the type of the actual argument was added to the error message and a new error code ERR_INVALID_ARRAY_LENGTH was added. PR-URL: #13739 Reviewed-By: Timothy Gu <firstname.lastname@example.org> Reviewed-By: Ben Noordhuis <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Anna Henningsen <email@example.com> Reviewed-By: Luigi Pinca <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com>