doc: update curl usage in COLLABORATOR_GUIDE #1382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but maybe add one or two lines to the commit log explaining the change. The idea is that when looking at the history, you don't have to look at the diff to figure out what the actual change was. |
|
Thanks, will do. |
silverwind
added a commit
that referenced
this pull request
Apr 9, 2015
Github now redirects the patch urls hosted on github.com, making it necessary to enable curl redirect handling to obtain patches in the merge process. Example (before and after): https://github.com/iojs/io.js/pull/1382.patch https://patch-diff.githubusercontent.com/raw/iojs/io.js/pull/1382.patch PR-URL: #1382 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in b464d46 |
|
btw there is apply-pr utility I wrote that has been pretty handy: https://github.com/petkaantonov/apply-pr Applying pr is like: |
|
Another option is to add |
|
Noted, but that is kinda annoying. cc @iojs/collaborators to notify the rest of the change. |
|
Another alternative is to make curl follow redirects by default: echo '-L' >> ~/.curlrc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Github now redirects the patch urls from
to
so curl now needs to follow that redirect.