Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: add napi_delete_element() #13949

Merged
merged 1 commit into from Jun 30, 2017
Merged

n-api: add napi_delete_element() #13949

merged 1 commit into from Jun 30, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 27, 2017

Refs: #13924

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Jun 27, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 30, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8903/

@cjihrig
n-api: add napi_delete_element()
f803e77 
Refs: nodejs#13924
PR-URL: nodejs#13949
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@cjihrig cjihrig merged commit f803e77 into nodejs:master Jun 30, 2017
@cjihrig cjihrig deleted the del-element branch June 30, 2017 21:11
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 3, 2017
@cjihrig @addaleax
n-api: add napi_delete_element()
aaf84ae 
Refs: nodejs#13924
PR-URL: nodejs#13949
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@addaleax addaleax mentioned this pull request Jul 3, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@cjihrig @addaleax
n-api: add napi_delete_element()
a5c4f4e 
Refs: #13924
PR-URL: #13949
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@cjihrig @addaleax
n-api: add napi_delete_element()
6316c9a 
Refs: #13924
PR-URL: #13949
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@cjihrig
n-api: add napi_delete_element()
ae0bdd5 
Refs: nodejs#13924
PR-URL: nodejs#13949
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@cjihrig @MylesBorins
n-api: add napi_delete_element()
cadec3b 
Refs: #13924
Backport-PR-URL: #19447
PR-URL: #13949
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasongin jasongin jasongin approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjihrig @jasongin @MylesBorins @nodejs-github-bot