Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: fix process.abort() interaction with V8 #13985

Closed
wants to merge 2 commits into from

Commits on Jun 29, 2017

  1. deps: cherry-pick 3f4536894ac from V8 upstream

    Original commit message:
    
        d8: Make in process stack dumping optional
    
        Adds a flag (--disable-in-process-stack-traces) to not install
        signal handlers so that e.g. ASan signal handlers will work.
    
        This flag mirrors chromium's one.
    
        R=jochen@chromium.org
        BUG=chromium:716235
    
        Review-Url: https://codereview.chromium.org/2854173002
        Cr-Commit-Position: refs/heads/master@{nodejs#45142}
    
    PR-URL: nodejs#13985
    oliverchang authored and addaleax committed Jun 29, 2017
    Copy the full SHA
    dc99526 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2017

  1. src: fix process.abort() interaction with V8

    Since V8 5.9 V8 installs a default signal handler for some signals
    when creating a default platform instance that prints a stack trace.
    
    However, Node already does the same thing, so it would seem like the
    two different stack traces would be printed; also, the V8 handler
    would lead to a `SIGSEGV` under some circumstances, rather than
    letting the abort continue normally.
    
    Resolve this by disabling V8’s signal handler by default.
    
    Fixes: nodejs#13865
    addaleax committed Jun 30, 2017
    Copy the full SHA
    9ca4062 View commit details
    Browse the repository at this point in the history