Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] doc, lib, test: do not re-require needlessly #14524

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] doc, lib, test: do not re-require needlessly #14524

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jul 27, 2017 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, process, repl, test, tls

Backport of #14244

@vsemozhetbyt
doc, lib, test: do not re-require needlessly
730b336 
PR-URL: #14244
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@nodejs-github-bot nodejs-github-bot added process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. tls Issues and PRs related to the tls subsystem. v8.x labels Jul 27, 2017
@vsemozhetbyt
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9383/

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Jul 27, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Jul 27, 2017
Closed
4 tasks
@addaleax addaleax self-assigned this Jul 28, 2017
@addaleax
Copy link
Member

Landed in eb023ef, thank you!

@addaleax addaleax closed this Jul 28, 2017
addaleax pushed a commit that referenced this pull request Jul 28, 2017
@vsemozhetbyt @addaleax
doc, lib, test: do not re-require needlessly
eb023ef 
Backport-PR-URL: #14524
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14244
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the backport-14244-to-v8.x branch July 28, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

@addaleax addaleax

Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsemozhetbyt @addaleax @nodejs-github-bot