Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: docs deprecation of 418 teapot status #14693

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 8, 2017

Docs-only deprecation of the I'm a teapot status for 9.x, with the intent of removing the unregistered status code by 10.x

Fixes: #14644

/cc @mnot

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http Issues or PRs related to the http subsystem. labels Aug 8, 2017
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 8, 2017
@@ -660,6 +660,19 @@ Type: Runtime

`REPLServer.parseREPLKeyword()` was removed from userland visibility.

<a id="DEP00XX"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this and the other instances be replaced?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value is assigned when PR lands.

Copy link
Member

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


Type: Documentation-only

The HTTP `418 I'm a teapot` status code was defined in [RFC2324][] as an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to note that 418 is not an HTTP status code, merely an HTCPCP one. I'd just remove the "HTTP" wording.

Copy link
Contributor

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a lot of people objecting to this proposal in #14644. I don't really have a strong opinion on teapot protocols myself, and I see how removing non-standardized behavior can be a good idea in general. However, at the moment I'm -1 for this because it doesn't seem like the benefits of removing the status code are worth the costs of removing something that a lot of people seem to like.

@jasnell
Copy link
Member Author

jasnell commented Aug 11, 2017

As amusing as the responses have been, I think you're right. Let's not do this yet. There are other approaches we can take later if the 418 status is ever actually assigned. We can't hate fun that much, can we?

@jasnell jasnell closed this Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http Issues or PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants