New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing word #14924

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@maclover7
Member

maclover7 commented Aug 18, 2017

Checklist

Add missing word to documentation.

Affected core subsystem(s)

doc

@addaleax

LGTM!

I don’t think this PR needs to wait the customary 48 hours.

@lpinca

lpinca approved these changes Aug 18, 2017

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Aug 18, 2017

Member

There is a typo in the commit message (mising).

Member

lpinca commented Aug 18, 2017

There is a typo in the commit message (mising).

@maclover7 maclover7 changed the title from doc: add mising word to doc: add missing word Aug 18, 2017

@Trott

Trott approved these changes Aug 18, 2017

LGTM. Might be a better word than build to use, especially because the word recurs shortly thereafter. Perhaps binary or executable? Or maybe this?:

If you have Node.js installed already, you can build just the docs with:

All that said, I'm fine with this as it is if there's no desire to make the changes I'm suggesting here.

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Aug 18, 2017

Member

@Trott before I submitted this PR I had build as installation locally, but I wasn't sure that was the right word, since this comes after instructions for manually building Node 😞

Member

maclover7 commented Aug 18, 2017

@Trott before I submitted this PR I had build as installation locally, but I wasn't sure that was the right word, since this comes after instructions for manually building Node 😞

jasnell added a commit that referenced this pull request Aug 18, 2017

doc: add missing word
PR-URL: #14924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 18, 2017

Member

Landed in 0914880! I see this was your first contribution! Thank you and welcome!

Member

jasnell commented Aug 18, 2017

Landed in 0914880! I see this was your first contribution! Thank you and welcome!

@jasnell jasnell closed this Aug 18, 2017

@maclover7 maclover7 deleted the maclover7:jm-doc branch Aug 18, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 18, 2017

Member

@Trott before I submitted this PR I had build as installation locally, but I wasn't sure that was the right word, since this comes after instructions for manually building Node 😞

It's all good. The most important thing is that the text be improved. If someone wants to come along and improve it even more later, that's great. If not, that's fine too. Thanks for taking the time to open a pull request! 🎉

Member

Trott commented Aug 18, 2017

@Trott before I submitted this PR I had build as installation locally, but I wasn't sure that was the right word, since this comes after instructions for manually building Node 😞

It's all good. The most important thing is that the text be improved. If someone wants to come along and improve it even more later, that's great. If not, that's fine too. Thanks for taking the time to open a pull request! 🎉

MylesBorins added a commit that referenced this pull request Sep 10, 2017

doc: add missing word
PR-URL: #14924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

doc: add missing word
PR-URL: #14924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

doc: add missing word
PR-URL: #14924
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment