Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aix: enable runtime linking #15286

Closed
wants to merge 1 commit into from
Closed

aix: enable runtime linking #15286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@
'common.gypi',
],

'ldflags': ['-Wl,-bE:<(PRODUCT_DIR)/node.exp'],
'ldflags': ['-Wl,-bE:<(PRODUCT_DIR)/node.exp', '-Wl,-brtl'],
},
{
'target_name': 'node_exp',
Expand Down
5 changes: 2 additions & 3 deletions test/addons/dlopen-ping-pong/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
'xcode_settings': {
'OTHER_LDFLAGS': [ '-Wl,-undefined', '-Wl,dynamic_lookup' ]
}}],
# Pass erok flag to the linker, to prevent unresolved symbols
# from failing. Still, the test won't pass, so we'll skip it on AIX.
# Enable the shared object to be linked by runtime linker
['OS=="aix"', {
'ldflags': [ '-Wl,-berok' ]
'ldflags': [ '-Wl,-G' ]
}]],
},
{
Expand Down
3 changes: 0 additions & 3 deletions test/addons/dlopen-ping-pong/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ const common = require('../../common');
if (common.isWindows)
common.skip('dlopen global symbol loading is not supported on this os.');

if (common.isAIX)
common.skip('this test does not pass on AIX.');

const assert = require('assert');
const path = require('path');
const os = require('os');
Expand Down