Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add support for link-module to vcbuild #15410

Closed
wants to merge 1 commit into from
Closed

build: add support for link-module to vcbuild #15410

wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Sep 14, 2017

Adds support for link-module option to vcbuild.bat.

Fixes: #15377

Checklist
Affected core subsystem(s)

win, build

@bzoz
build: add support for link-module to vcbuild
f69a62b 
Adds support for link-module option to vcbuild.bat.

Fixes: nodejs#15377
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Sep 14, 2017
@bzoz bzoz mentioned this pull request Sep 14, 2017
Closed
@anmonteiro
Copy link

anmonteiro commented Sep 14, 2017 •
edited

On the Linux side , --link-module can appear multiple times. Does this patch mimic that behavior?

@bzoz
Copy link
Contributor Author

bzoz commented Sep 14, 2017

Yes, like vcbuild link-module module1.js link-module module2.js

refack
refack approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@refack
Copy link
Contributor

refack commented Sep 14, 2017

I had an idea about how to test configure and vcbuild by manipulating %Path%. I need to put thoughts into action.

@BridgeAR
Copy link
Member

Landed in e86952d

@BridgeAR BridgeAR closed this Sep 19, 2017
BridgeAR pushed a commit that referenced this pull request Sep 19, 2017
@bzoz @BridgeAR
build: add support for link-module to vcbuild
e86952d 
Adds support for link-module option to vcbuild.bat.

PR-URL: #15410
Fixes: #15377
Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@bzoz @jasnell
build: add support for link-module to vcbuild
5d217ad 
Adds support for link-module option to vcbuild.bat.

PR-URL: #15410
Fixes: #15377
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@bzoz
build: add support for link-module to vcbuild
8ceb08a 
Adds support for link-module option to vcbuild.bat.

PR-URL: nodejs/node#15410
Fixes: nodejs/node#15377
Reviewed-By: Refael Ackermann <refack@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@bzoz
build: add support for link-module to vcbuild
8db4f20 
Adds support for link-module option to vcbuild.bat.

PR-URL: nodejs/node#15410
Fixes: nodejs/node#15377
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins
Copy link
Member

This does not land cleanly in v6.x LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--link-module Windows support?
6 participants
@bzoz @anmonteiro @refack @BridgeAR @MylesBorins @nodejs-github-bot