doc: update fs.utimes{,Sync} changelog #15680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid values for the `atime` and `mtime` arguments. Fixes: nodejs#15453
nodejs-github-bot
added
doc
cjihrig
approved these changes
Sep 29, 2017
jasnell
approved these changes
Sep 29, 2017
BridgeAR
approved these changes
Oct 1, 2017
|
Landed in c8a2143 |
Merged
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 4, 2017
Fixes YAML parsing issues introduced in c8a2143. Refs: nodejs#15680
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid values for the `atime` and `mtime` arguments. PR-URL: nodejs/node#15680 Fixes: nodejs/node#15453 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Closed
|
This PR possibly breaks doc building. Refs: |
|
@vsemozhetbyt #15769 has enough LGTMs and it's a trivial change. Feel free to land it if you have time. |
|
Fixing PR: #15788 |
|
Oops, sorry, did not see that, I will close mine and land yours, |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Oct 5, 2017
Fixes YAML parsing issues introduced in c8a2143. PR-URL: #15769 Refs: #15680 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 7, 2017
Fixes YAML parsing issues introduced in c8a2143. PR-URL: #15769 Refs: #15680 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Fixes YAML parsing issues introduced in c8a2143. PR-URL: #15769 Refs: #15680 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Fixes YAML parsing issues introduced in c8a2143. PR-URL: nodejs/node#15769 Refs: nodejs/node#15680 Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that
NaN,Infinity, and-Infinityare no longer validvalues for the
atimeandmtimearguments.Fixes: #15453
Checklist
Affected core subsystem(s)
doc