Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update common.fixturesDir usage with fixtures.fixturesDir #15874

Closed
wants to merge 1 commit into from
Closed

test: update common.fixturesDir usage with fixtures.fixturesDir #15874

wants to merge 1 commit into from

Conversation

alvaro450
Copy link
Contributor

@alvaro450 alvaro450 commented Oct 6, 2017 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@Trott
Copy link
Member

Trott commented Oct 8, 2017

Hi, @alvaro450! Welcome and thanks for this! Can you update this to use fixtures.readKey()?
The docs are at https://github.com/nodejs/node/tree/master/test/common#fixtures-module. Also, the comment added should likely be removed. It doesn't say anything that isn't obvious from the line it's commenting on and we don't include that comment in any of the many other files that use the fixtures module.

jasnell
jasnell reviewed Oct 10, 2017
View reviewed changes
test/parallel/test-tls-getcipher.js
key: fs.readFileSync(`${common.fixturesDir}/keys/agent2-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent2-cert.pem`),
key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent2-key.pem`),
cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent2-cert.pem`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be:

key: fixtures.readKey('agent2-key.pem'),
cert: fixtures.readKey('agent2-cert.pem')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this while landing.

BridgeAR
BridgeAR approved these changes Oct 18, 2017
View reviewed changes
test/parallel/test-tls-getcipher.js
key: fs.readFileSync(`${common.fixturesDir}/keys/agent2-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent2-cert.pem`),
key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent2-key.pem`),
cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent2-cert.pem`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this while landing.

BridgeAR pushed a commit that referenced this pull request Oct 19, 2017
@alvaro450 @BridgeAR
test: use fixtures module
b096533 
PR-URL: #15874
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in b096533

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 19, 2017
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@alvaro450 @MylesBorins
test: use fixtures module
48ae4e0 
PR-URL: #15874
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@alvaro450 @addaleax
test: use fixtures module
70f3627 
PR-URL: nodejs/node#15874
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@alvaro450 @MylesBorins
test: use fixtures module
71c3c4b 
PR-URL: #15874
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@alvaro450 @MylesBorins
test: use fixtures module
2dee43e 
PR-URL: #15874
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@alvaro450 @MylesBorins
test: use fixtures module
c58eaaf 
PR-URL: #15874
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@alvaro450 @addaleax
test: use fixtures module
e95043a 
PR-URL: nodejs/node#15874
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alvaro450 @Trott @BridgeAR @jasnell @mscdex @MylesBorins @nodejs-github-bot