test: check session timeout in http2 #16754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two instances of a similar test exist, with both testing the timeout on the stream and neither on the session. Adjust one of them to test the session timeout instead.
apapirovski
added
http2
jasnell
approved these changes
Nov 5, 2017
cjihrig
approved these changes
Nov 5, 2017
|
CI Failed on the arm devices... trying again https://ci.nodejs.org/job/node-test-commit-arm-fanned/12314/ |
|
Landed in daeb7a6 |
apapirovski
added a commit
that referenced
this pull request
Nov 7, 2017
Two instances of a similar test exist, with both testing the timeout on the stream and neither on the session. Adjust one of them to test the session timeout instead. PR-URL: #16754 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
Two instances of a similar test exist, with both testing the timeout on the stream and neither on the session. Adjust one of them to test the session timeout instead. PR-URL: #16754 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
Two instances of a similar test exist, with both testing the timeout on the stream and neither on the session. Adjust one of them to test the session timeout instead. PR-URL: #16754 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two instances of a similar test exist, with both testing the timeout on the stream and neither on the session. Adjust one of them to test the session timeout instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test