Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
test: add a test description for test/parallel/test-cluster-fork-env.js #16833
Add value to assertion message to test-cluster-fork-env.js test
Affected core subsystem(s)
Trott left a comment
Hi @grantgasp! Welcome and thanks for the PR!
Given that we can be certain the values checked are booleans, I'm not sure that adding this info to the messages is helpful. This is an error in the task I curated and not anything you did. I'm terribly sorry about that.
However, there are definitely things that can be done to improve this test.
I'd recommend removing the changes you did and instead adding a comment (below the declaration of
Would you mind doing that? I know it's not much of a change, but it's an improvement, and as a first contribution, it will allow you to see how our process works.