test: use fixtures module for path resolve #16842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Nov 6, 2017
cjihrig
approved these changes
Nov 6, 2017
Trott
added
the
code-and-learn
Trott
approved these changes
Nov 6, 2017
Trott
requested changes
Nov 6, 2017
There was a problem hiding this comment.
Hi, @sercanyersen! Welcome and thanks for the PR! Because path is no longer used, the linter is complaining about its declaration. Can you remove it, commit to your branch, and push it up to GitHub so the changes show up in this PR? (Also, you can run make lint-js to see JS lint issues, if any.)
lpinca
reviewed
Nov 7, 2017
| @@ -1,6 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| const common = require('../common'); | |||
| const fixtures = require('../common/fixtures'); | |||
There was a problem hiding this comment.
Nit: can you please move this after the common.hasCrypto check?
Trott
approved these changes
Nov 8, 2017
jasnell
approved these changes
Nov 8, 2017
lpinca
approved these changes
Nov 8, 2017
|
Retrying the one failed CI platform; https://ci.nodejs.org/job/node-test-commit-arm-fanned/12516/ |
gireeshpunathil
approved these changes
Nov 13, 2017
|
Retrying Raspberry Pi again in the hopes it builds successfully this time: https://ci.nodejs.org/job/node-test-commit-arm-fanned/12540/ |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #16842 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
Landed in 803cacd , thanks for the contribution! |
evanlucas
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #16842 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
PR-URL: #16842 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the fixture use normalization process commit.
Changes in just one file where the path.resolve method replaced with fixtures.path.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test