Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Replace String concatenation with template #16922

Closed
wants to merge 1 commit into from
Closed

lib: Replace String concatenation with template #16922

wants to merge 1 commit into from

Conversation

saiHemak
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 10, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
sreepurnajasti
sreepurnajasti reviewed Nov 10, 2017
View reviewed changes
lib/internal/v8_prof_polyfill.js Outdated
@@ -79,7 +79,7 @@ var line = '';

function peekline() {
const s = readline();
line = s + '\n' + line;
line = `s \n` + line;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change s as ${s} as we need to append the const variable s instead of the letter s.

jasnell
jasnell reviewed Nov 10, 2017
View reviewed changes
lib/internal/v8_prof_polyfill.js Outdated
@@ -79,7 +79,7 @@ var line = '';

function peekline() {
const s = readline();
line = s + '\n' + line;
line = `${s} \n` + line;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can cover the entire line... e.g.

line = `${s} \n${line}`;

@saiHemak
Copy link
Contributor Author

@jasnell Thanks for your review.I have addressed your comments

@fhinkel
Copy link
Member

fhinkel commented Nov 11, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11356/

@fhinkel
Copy link
Member

fhinkel commented Nov 11, 2017

CI failures unrelated.

@saiHemak Thanks so much for your first commit 🎉. Landed as d8f1cb4.

@fhinkel fhinkel closed this Nov 11, 2017
fhinkel pushed a commit that referenced this pull request Nov 11, 2017
@saiHemak @fhinkel
lib: replace String concatenation with template
d8f1cb4 
PR-URL: #16922
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@saiHemak @evanlucas
lib: replace String concatenation with template
8eb32e1 
PR-URL: #16922
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreepurnajasti sreepurnajasti sreepurnajasti left review comments

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@saiHemak @fhinkel @jasnell @cjihrig @tniessen @gireeshpunathil @sreepurnajasti @MylesBorins @nodejs-github-bot