http: flush stored header #1695
Conversation
| @@ -5,7 +5,7 @@ const http = require('http'); | |||
|
|
|||
| const server = http.createServer(); | |||
| server.on('request', function(req, res){ | |||
| assert(req.headers['foo'], 'bar'); | |||
| assert(req.headers['foo'] === 'bar'); | |||
There was a problem hiding this comment.
just an unrelated fix. bar was used as a message, not as expected value
There was a problem hiding this comment.
Ah I see now. Maybe it would be better to change this to assert.equal() instead, that way if the assertion should fail, it will show the two non-matching values in the message instead of just "false."
There was a problem hiding this comment.
yep, it is better!
vkurchatkin
force-pushed
the
fix-flush-headers
branch
from
4deb05b
to
a486d0c
Compare
|
|
||
| const server = http.createServer(); | ||
|
|
||
| server.on('request', function(req, res){ |
There was a problem hiding this comment.
sorry, style: space in (req, res) {
vkurchatkin
force-pushed
the
fix-flush-headers
branch
from
a486d0c
to
e416156
Compare
| server.on('request', function(req, res) { | ||
| res.writeHead(200, {'foo': 'bar'}); | ||
| res.flushHeaders(); | ||
| res.flushHeaders(); |
There was a problem hiding this comment.
what the second flushHeaders() call is for?
There was a problem hiding this comment.
Saw another test doing this. flushHeaders should be idempotent, this validates that nothing fatal happens if it is called twice
There was a problem hiding this comment.
Could you add that as a comment to the second flushHeaders call?
|
LGTM with a comment. Is the CI happy? |
|
CI is happy, @vkurchatkin are you able to update this? |
`flushHeaders` should work for header written with `writeHead`.
vkurchatkin
force-pushed
the
fix-flush-headers
branch
from
e416156
to
01b7a80
Compare
|
updated! @Fishrock123 can you start CI, it's a shame but I have no idea how do it |
|
@vkurchatkin https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/723/ Ping me on IRC if you want instructions on how to start a job (assuming you have an account.) |
`flushHeaders` should work for header written with `writeHead`. PR-URL: #1695 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
All is green! this is really satisfying :-). Landed in 2c686fd |
`flushHeaders` should work for header written with `writeHead`. PR-URL: nodejs/node#1695 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
flushHeadersshould work for header written withwriteHead.R=@bnoordhuis