Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: remove deprecated API #17147

Closed
wants to merge 2 commits into from
Closed

async_hooks: remove deprecated API #17147

wants to merge 2 commits into from

Conversation

AndreasMadsen
Copy link
Member

@AndreasMadsen AndreasMadsen commented Nov 20, 2017 •
edited
Loading

Ref: #16972

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

async_hooks

/cc @nodejs/async_hooks

@nodejs-github-bot nodejs-github-bot added the async_hooks Issues and PRs related to the async hooks subsystem. label Nov 20, 2017
@AndreasMadsen AndreasMadsen added dont-land-on-v4.x semver-major PRs that contain breaking changes and should be released in the next major version. labels Nov 20, 2017
@AndreasMadsen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11544/

@AndreasMadsen AndreasMadsen mentioned this pull request Nov 20, 2017
Closed
20 tasks
@AndreasMadsen
Copy link
Member Author

Let's never speak of that mistake.

CI: https://ci.nodejs.org/job/node-test-pull-request/11551/

@AndreasMadsen
Copy link
Member Author

Landed in 1cc6b99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndreasMadsen @jasnell @cjihrig @nodejs-github-bot