Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use crashOnUnhandledRejection #17220

Closed
wants to merge 1 commit into from
Closed

test: use crashOnUnhandledRejection #17220

wants to merge 1 commit into from

Conversation

imZack
Copy link
Contributor

@imZack imZack commented Nov 22, 2017

Add common.crashOnUnhandledRejection right after main require statements

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@imZack
test: use crashOnUnhandledRejection
5fc4189 
Add common.crashOnUnhandledRejection to
test/parallel/test-async-hooks-disable-during-promise.js
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
@imZack imZack changed the title test: add crashOnUnhandledRejection test: use crashOnUnhandledRejection Nov 22, 2017
MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11611/

@MylesBorins MylesBorins added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdex mscdex added the async_hooks Issues and PRs related to the async hooks subsystem. label Nov 22, 2017
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

One failure in CI is unrelated.

jasnell pushed a commit that referenced this pull request Nov 22, 2017
@imZack @jasnell
test: use crashOnUnhandledRejection
5d6693f 
Add common.crashOnUnhandledRejection to
test/parallel/test-async-hooks-disable-during-promise.js

PR-URL: #17220
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Landed in 5d6693f! Thank you and congrats on your PR to core!

@jasnell jasnell closed this Nov 22, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@imZack @MylesBorins
test: use crashOnUnhandledRejection
07ae65d 
Add common.crashOnUnhandledRejection to
test/parallel/test-async-hooks-disable-during-promise.js

PR-URL: #17220
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@imZack @MylesBorins
test: use crashOnUnhandledRejection
c232542 
Add common.crashOnUnhandledRejection to
test/parallel/test-async-hooks-disable-during-promise.js

PR-URL: #17220
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@imZack @gibfahn
test: use crashOnUnhandledRejection
a47b55d 
Add common.crashOnUnhandledRejection to
test/parallel/test-async-hooks-disable-during-promise.js

PR-URL: #17220
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@imZack @gibfahn
test: use crashOnUnhandledRejection
92d4d1e 
Add common.crashOnUnhandledRejection to
test/parallel/test-async-hooks-disable-during-promise.js

PR-URL: #17220
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@imZack @MylesBorins @jasnell @cjihrig @gireeshpunathil @mscdex @gibfahn @nodejs-github-bot