Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update test-http-response-status-message to use countdown timer #17326

Closed
wants to merge 1 commit into from
Closed

test: Update test-http-response-status-message to use countdown timer #17326

wants to merge 1 commit into from

Conversation

daxlab
Copy link
Contributor

@daxlab daxlab commented Nov 26, 2017 •
edited by apapirovski

Refs: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@daxlab daxlab force-pushed the test-http-response-status-message branch from 57f3420 to 3e476cc Compare November 26, 2017 17:51
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 26, 2017
@Trott
Copy link
Member

Trott commented Nov 28, 2017

If I'm not mistaken, this and the other should be "Refs" for that issue and not "Fixes".

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11875/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2017
@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11983/

@Leko Leko mentioned this pull request Dec 8, 2017
Closed
3 tasks
apapirovski
apapirovski reviewed Dec 8, 2017
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daxlab — thanks for taking this on! This is a good start but right now this test is still not using Countdown to its full potential. Instead of passing around testCaseIndex, we could just use testCases.length - countdown.remaining for the index and the check for runTest could be countdown.remaining > 0.

Let me know if you have any questions!

@apapirovski apapirovski closed this Dec 8, 2017
@apapirovski apapirovski reopened this Dec 8, 2017
@apapirovski apapirovski removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 9, 2017
BridgeAR
BridgeAR approved these changes Dec 10, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would be good to get the suggestion from @apapirovski in as well.

@maclover7 maclover7 added the wip Issues and PRs that are still a work in progress. label Dec 11, 2017
@maclover7
Copy link
Contributor

ping @daxlab

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed wip Issues and PRs that are still a work in progress. labels Jan 19, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 21, 2018
@daxlab @BridgeAR
test: use countdown timer
7d2b08a 
PR-URL: nodejs#17326
Refs: nodejs#17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 7d2b08a

@BridgeAR BridgeAR closed this Jan 21, 2018
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@daxlab @evanlucas
test: use countdown timer
aa96858 
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@daxlab @evanlucas
test: use countdown timer
fc89cea 
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@daxlab @MylesBorins
test: use countdown timer
27107b9 
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@daxlab @MylesBorins
test: use countdown timer
0e6cb3f 
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Feb 27, 2018
Closed
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@daxlab @MayaLekova
test: use countdown timer
a845978 
PR-URL: nodejs#17326
Refs: nodejs#17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski left review comments

@jasnell jasnell jasnell approved these changes

@maclover7 maclover7 maclover7 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@daxlab @Trott @maclover7 @BridgeAR @apapirovski @jasnell @mscdex @MylesBorins @nodejs-github-bot