Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update test-http-response-status-message to use countdown timer #17326

Closed

Conversation

Projects
None yet
9 participants
@daxlab
Copy link
Member

commented Nov 26, 2017

Refs: #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@daxlab daxlab force-pushed the daxlab:test-http-response-status-message branch from 57f3420 to 3e476cc Nov 26, 2017

@mscdex mscdex added the http label Nov 26, 2017

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 28, 2017

If I'm not mistaken, this and the other should be "Refs" for that issue and not "Fixes".

@maclover7

This comment has been minimized.

@jasnell

jasnell approved these changes Dec 5, 2017

@maclover7

This comment has been minimized.

@MylesBorins MylesBorins force-pushed the nodejs:master branch from b7405ab to 7f086dd Dec 8, 2017

@Leko Leko referenced this pull request Dec 8, 2017

Closed

Update test-http-response-status-message to use Countdown #17552

3 of 3 tasks complete
@apapirovski
Copy link
Member

left a comment

Hi @daxlab — thanks for taking this on! This is a good start but right now this test is still not using Countdown to its full potential. Instead of passing around testCaseIndex, we could just use testCases.length - countdown.remaining for the index and the check for runTest could be countdown.remaining > 0.

Let me know if you have any questions!

@apapirovski apapirovski closed this Dec 8, 2017

@apapirovski apapirovski reopened this Dec 8, 2017

@BridgeAR
Copy link
Member

left a comment

LGTM but it would be good to get the suggestion from @apapirovski in as well.

@maclover7

This comment has been minimized.

Copy link
Member

commented Dec 19, 2017

ping @daxlab

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 21, 2018

test: use countdown timer
PR-URL: nodejs#17326
Refs: nodejs#17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Jan 21, 2018

Landed in 7d2b08a

@BridgeAR BridgeAR closed this Jan 21, 2018

maclover7 added a commit that referenced this pull request Jan 26, 2018

test: use countdown timer
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

evanlucas added a commit that referenced this pull request Jan 30, 2018

test: use countdown timer
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

evanlucas added a commit that referenced this pull request Jan 30, 2018

test: use countdown timer
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use countdown timer
PR-URL: nodejs#17326
Refs: nodejs#17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use countdown timer
PR-URL: nodejs#17326
Refs: nodejs#17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 27, 2018

test: use countdown timer
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Feb 27, 2018

test: use countdown timer
PR-URL: #17326
Refs: #17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

This was referenced Feb 27, 2018

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

test: use countdown timer
PR-URL: nodejs#17326
Refs: nodejs#17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.