Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: refactoring in preparation for promises support #17689

Closed
wants to merge 3 commits into from
Closed

fs: refactoring in preparation for promises support #17689

wants to merge 3 commits into from

Commits on Dec 18, 2017

  1. fs: refactor FSReqWrap and After 

    Separate FSReqWrap definition into a new node_file.h.

Add Reject and Resolve methods to encapsulate the callbacks and
make the constructor, destructor protected instead of private
in preparation to make FSReqWrap subclassable for the Promises
implementation.

Rework and simplify the After function slightly in preparation
for a refactor.

Introduce the node::fs namespace instead of using an anonymous
namespace for fs methods.
    @jasnell
    jasnell committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    fbc3961 View commit details
    Browse the repository at this point in the history

  2. fs: refactor After for easier maintainability

    @jasnell
    jasnell committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    6b18e12 View commit details
    Browse the repository at this point in the history

  3. fs: remove unused macro

    @jasnell
    jasnell committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    7656875 View commit details
    Browse the repository at this point in the history