Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: rename On* -> Emit* for stream callbacks #17701

Closed
wants to merge 1 commit into from
Closed

src: rename On* -> Emit* for stream callbacks #17701

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This should make these function calls a lot more intuitive for people who are more accustomed to Node’s EventEmitter API.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/stream_base

@addaleax
src: rename On* -> Emit* for stream callbacks
509ca7a 
This should make these function calls a lot more intuitive for people
who are more accustomed to Node’s EventEmitter API.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 15, 2017
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 15, 2017
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/14874/

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 15, 2017
@addaleax
Copy link
Member Author

Landed in 2ac7ade

@addaleax addaleax closed this Dec 16, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 16, 2017
@addaleax addaleax deleted the on2emit branch December 16, 2017 15:32
addaleax added a commit that referenced this pull request Dec 16, 2017
@addaleax
src: rename On* -> Emit* for stream callbacks
2ac7ade 
This should make these function calls a lot more intuitive for people
who are more accustomed to Node’s EventEmitter API.

PR-URL: #17701
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@addaleax @MylesBorins
src: rename On* -> Emit* for stream callbacks
37ed0a7 
This should make these function calls a lot more intuitive for people
who are more accustomed to Node’s EventEmitter API.

PR-URL: #17701
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@addaleax @MylesBorins
src: rename On* -> Emit* for stream callbacks
d84d9be 
This should make these function calls a lot more intuitive for people
who are more accustomed to Node’s EventEmitter API.

PR-URL: #17701
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@MylesBorins
Copy link
Contributor

This change will need to be manually backported to v6.x and v8.x.

@MylesBorins

This comment has been minimized.

Sign in to view
@addaleax addaleax added this to To do in StreamBase refactor via automation Apr 1, 2018
@addaleax addaleax moved this from To do to Done in StreamBase refactor Apr 1, 2018
@MylesBorins
Copy link
Contributor

ping @addaleax re: backport

@addaleax
Copy link
Member Author

@MylesBorins I think you just backported the PR that this depends on. 😄

@MylesBorins
Copy link
Contributor

a++

MylesBorins pushed a commit that referenced this pull request May 23, 2018
@addaleax @MylesBorins
src: rename On* -> Emit* for stream callbacks
0082efd 
This should make these function calls a lot more intuitive for people
who are more accustomed to Node’s EventEmitter API.

PR-URL: #17701
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@addaleax @MylesBorins
src: rename On* -> Emit* for stream callbacks
fafcaa1 
This should make these function calls a lot more intuitive for people
who are more accustomed to Node’s EventEmitter API.

PR-URL: #17701
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@addaleax @rvagg
src: rename On* -> Emit* for stream callbacks
a8d2ab5 
This should make these function calls a lot more intuitive for people
who are more accustomed to Node’s EventEmitter API.

PR-URL: #17701
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
No open projects
StreamBase refactor
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@addaleax @MylesBorins @apapirovski @TimothyGu @cjihrig @BridgeAR @nodejs-github-bot