tools: auto fix custom eslint rule for lowercase-name-for-primitive.js #17715

shobhitchittora · 2017-12-17T10:45:13Z

Refs: #16636

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
modify tests

Affected core subsystem(s)

Tools

shobhitchittora · 2017-12-17T10:46:57Z

Hey @apapirovski @BridgeAR .
Please review this.

cjihrig · 2017-12-17T17:12:07Z

tools/eslint-rules/lowercase-name-for-primitive.js

@@ -35,9 +35,20 @@ module.exports = function(context) {
  function checkName(node, name) {
    const lowercaseName = name.toLowerCase();
    if (primitives.includes(lowercaseName) && !primitives.includes(name)) {
+      console.log(lowercaseName);


Please remove the console.log()

Yeah forgot it was there! Removed 👍🏻.

Trott · 2017-12-17T17:28:08Z

Do we usually have tests for fixer functions? /cc @not-an-aardvark

shobhitchittora · 2017-12-17T17:33:40Z

@Trott not afaik.

Trott · 2017-12-17T17:41:38Z

@shobhitchittora Looks good to me. Thanks for the pull request!

1. Fixer for lowercase-name-for-primitive.js 2. Modified the node passed to fix it. Refs : nodejs#16636

starkwang · 2017-12-18T01:57:25Z

Hi @shobhitchittora ! Thank you for working on this!

Could you expand the test in /test/parallel/test-eslint-lowercase-name-for-primitive.js for the auto fixer ? (simply add the output prop in invalid array)

Here is an example to see how it works: /test/parallel/test-eslint-no-let-in-for-declaration.js

Happy to approve again after @strakwang's requested test is implemented.

1. Extends test cases with output scenarios. Refs : nodejs#16636

shobhitchittora · 2017-12-18T05:09:50Z

@starkwang Thanks for the heads up.
@Trott extended the tests.

apapirovski

Seems good but a bit of clean up would be nice.

apapirovski · 2017-12-18T18:34:03Z

tools/eslint-rules/lowercase-name-for-primitive.js

-        names.elements.forEach((name) => {
-          checkName(node, name.value);
+        names.elements.forEach((name, index) => {
+          checkName(names.elements[index], name.value);


Couldn't this just be name instead of names.elements[index]? Pretty sure we can also get rid of the second argument here and above.

apapirovski · 2017-12-18T18:34:28Z

tools/eslint-rules/lowercase-name-for-primitive.js

@@ -36,8 +36,18 @@ module.exports = function(context) {
    const lowercaseName = name.toLowerCase();
    if (primitives.includes(lowercaseName) && !primitives.includes(name)) {


name could just be replaced with node.value now.

Also, pretty sure !primitives.includes(name) could be simplified to name !== lowercaseName (and it could be put as the first condition so the includes only runs if necessary).

Made the changes.

apapirovski · 2017-12-18T18:40:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/31/

1. Changes as per review comments. Refs : nodejs#16636

apapirovski · 2017-12-24T15:15:43Z

CI to merge: https://ci.nodejs.org/job/node-test-pull-request-lite/42/

starkwang · 2017-12-25T06:38:51Z

test/parallel/test-eslint-lowercase-name-for-primitive.js

@@ -23,19 +23,23 @@ new RuleTester().run('lowercase-name-for-primitive', rule, {
  invalid: [
    {
      code: 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "a", "Number")',
-      errors: [{ message: 'primitive should use lowercase: Number' }]
+      errors: [{ message: 'primitive should use lowercase: Number' }],
+      output: 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "a", "number")'


CI failed due to a small problem:
The input code and expected output are using double quotes ", but the autofixer will change it to single quotes, which makes the actual output cannot match the expected output.

@shobhitchittora Could you change these double quotes in code and output to using single quotes?

@starkwang pushed a fix. How did you check the problem in Jenkins that the output is not correct?

I modified some codes in eslint (eslint/lib/testers/rule-tester.js) to expose the error message.
You can see eslint/eslint#9769 for more detail. 😉

starkwang · 2017-12-25T07:37:32Z

I also send a PR to eslint for more detailed assert message: eslint/eslint#9769

1. Fixed test with proper quotes. Refs : nodejs#16636

starkwang · 2017-12-26T01:46:14Z

New CI: https://ci.nodejs.org/job/node-test-pull-request-lite/44/

starkwang · 2017-12-26T02:01:05Z

The CI failed again:

Received:
'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\',\n            \'number\')'

Expected:
'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\',\n              \'number\')'

starkwang · 2017-12-26T02:06:58Z

test/parallel/test-eslint-lowercase-name-for-primitive.js

-      code: 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "a", "Number")',
-      errors: [{ message: 'primitive should use lowercase: Number' }]
+      code: `new errors.TypeError('ERR_INVALID_ARG_TYPE', 'a',
+            'Number')`,


@shobhitchittora Could you change these backquote to singlequote? For example:

{ code: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' + '\'Number\'' }

In addition, you can use this command to check if your change will pass CI:

node test/parallel/test-eslint-lowercase-name-for-primitive.js

Done and started a build.

1. Removes template string 2. Uses escaped quote. Refs : nodejs#16636

starkwang · 2017-12-26T04:32:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/47/

starkwang · 2017-12-26T05:53:22Z

Landed in 639770c 💯 🥇

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 17, 2017

shobhitchittora force-pushed the lowercase-name-for-primitive-fixer branch from 8654800 to 594ae58 Compare December 17, 2017 10:49

cjihrig reviewed Dec 17, 2017

View reviewed changes

shobhitchittora force-pushed the lowercase-name-for-primitive-fixer branch from 594ae58 to ece39e7 Compare December 17, 2017 17:24

Trott previously approved these changes Dec 17, 2017

View reviewed changes

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js

a389548

1. Fixer for lowercase-name-for-primitive.js 2. Modified the node passed to fix it. Refs : nodejs#16636

shobhitchittora force-pushed the lowercase-name-for-primitive-fixer branch from ece39e7 to a389548 Compare December 17, 2017 17:53

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js

b2d1f5b

1. Extends test cases with output scenarios. Refs : nodejs#16636

apapirovski approved these changes Dec 18, 2017

View reviewed changes

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js

42009c2

1. Changes as per review comments. Refs : nodejs#16636

starkwang reviewed Dec 25, 2017

View reviewed changes

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js

1799ec3

1. Fixed test with proper quotes. Refs : nodejs#16636

starkwang reviewed Dec 26, 2017

View reviewed changes

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js

a23ca88

1. Removes template string 2. Uses escaped quote. Refs : nodejs#16636

starkwang approved these changes Dec 26, 2017

View reviewed changes

starkwang closed this Dec 26, 2017

starkwang pushed a commit that referenced this pull request Dec 26, 2017

tools: autofixer for lowercase-name-for-primitive

639770c

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

shobhitchittora deleted the lowercase-name-for-primitive-fixer branch December 26, 2017 07:14

MylesBorins pushed a commit that referenced this pull request Jan 8, 2018

tools: autofixer for lowercase-name-for-primitive

034c998

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

MylesBorins pushed a commit that referenced this pull request Jan 9, 2018

tools: autofixer for lowercase-name-for-primitive

ce25443

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

MylesBorins pushed a commit that referenced this pull request Jan 9, 2018

tools: autofixer for lowercase-name-for-primitive

2d07243

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

MylesBorins mentioned this pull request Jan 10, 2018

v9.4.0 proposal #18069

Merged

gibfahn pushed a commit that referenced this pull request Jan 24, 2018

tools: autofixer for lowercase-name-for-primitive

2ed63d1

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

gibfahn pushed a commit that referenced this pull request Jan 24, 2018

tools: autofixer for lowercase-name-for-primitive

eee6cd0

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

gibfahn added land-on-v6.x labels Jan 24, 2018

gibfahn pushed a commit that referenced this pull request Jan 24, 2018

tools: autofixer for lowercase-name-for-primitive

f88afb4

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

MylesBorins mentioned this pull request Jan 24, 2018

v6.13.0 proposal #18342

Merged

MylesBorins pushed a commit that referenced this pull request Feb 11, 2018

tools: autofixer for lowercase-name-for-primitive

7790887

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

MylesBorins pushed a commit that referenced this pull request Feb 12, 2018

tools: autofixer for lowercase-name-for-primitive

b9c6922

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

MylesBorins pushed a commit that referenced this pull request Feb 13, 2018

tools: autofixer for lowercase-name-for-primitive

6187aec

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js #17715

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js #17715

shobhitchittora commented Dec 17, 2017 •

edited

shobhitchittora commented Dec 17, 2017

cjihrig Dec 17, 2017

shobhitchittora Dec 17, 2017

Trott commented Dec 17, 2017

shobhitchittora commented Dec 17, 2017

Trott commented Dec 17, 2017

starkwang commented Dec 18, 2017 •

edited

shobhitchittora commented Dec 18, 2017

apapirovski left a comment

apapirovski Dec 18, 2017

shobhitchittora Dec 19, 2017

apapirovski Dec 18, 2017 •

edited

shobhitchittora Dec 19, 2017

apapirovski commented Dec 18, 2017

apapirovski commented Dec 24, 2017

starkwang Dec 25, 2017

starkwang Dec 25, 2017

shobhitchittora Dec 25, 2017 •

edited

starkwang Dec 25, 2017

starkwang commented Dec 25, 2017

starkwang commented Dec 26, 2017

starkwang commented Dec 26, 2017

starkwang Dec 26, 2017

shobhitchittora Dec 26, 2017

starkwang commented Dec 26, 2017

starkwang commented Dec 26, 2017

		@@ -36,8 +36,18 @@ module.exports = function(context) {
		const lowercaseName = name.toLowerCase();
		if (primitives.includes(lowercaseName) && !primitives.includes(name)) {

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js #17715

tools: auto fix custom eslint rule for lowercase-name-for-primitive.js #17715

Conversation

shobhitchittora commented Dec 17, 2017 • edited

Affected core subsystem(s)

shobhitchittora commented Dec 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trott commented Dec 17, 2017

shobhitchittora commented Dec 17, 2017

Trott commented Dec 17, 2017

starkwang commented Dec 18, 2017 • edited

shobhitchittora commented Dec 18, 2017

apapirovski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apapirovski Dec 18, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apapirovski commented Dec 18, 2017

apapirovski commented Dec 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shobhitchittora Dec 25, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

starkwang commented Dec 25, 2017

starkwang commented Dec 26, 2017

starkwang commented Dec 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

starkwang commented Dec 26, 2017

starkwang commented Dec 26, 2017

shobhitchittora commented Dec 17, 2017 •

edited

starkwang commented Dec 18, 2017 •

edited

apapirovski Dec 18, 2017 •

edited

shobhitchittora Dec 25, 2017 •

edited