Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: update make for new code coverage locations #17987

Closed
wants to merge 1 commit into from
Closed

src: update make for new code coverage locations #17987

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jan 5, 2018

The files for code coverage are moving to the build
repository. Update the references to reflect this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mhdawson
src: update make for new code coverage locations
b1b78f4 
The files for code coverage are moving to the build
repository.  Update the references to reflect this.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 5, 2018
@mhdawson mhdawson mentioned this pull request Jan 5, 2018
Closed
maclover7
maclover7 approved these changes Jan 5, 2018
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally, LGTM

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12433/
Coverage CI (to make sure things still work): https://ci.nodejs.org/job/node-test-commit-linux-coverage/491/

@mhdawson
Copy link
Member Author

mhdawson commented Jan 8, 2018

CI failure was an infra issue so its ok and Code coverage run was good, landing.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 8, 2018

Landed as c91bd2f

@mhdawson mhdawson closed this Jan 8, 2018
mhdawson added a commit that referenced this pull request Jan 8, 2018
@mhdawson
src: update make for new code coverage locations
c91bd2f 
The files for code coverage are moving to the build
repository.  Update the references to reflect this.

PR-URL: #17987
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@mhdawson @MylesBorins
src: update make for new code coverage locations
b191285 
The files for code coverage are moving to the build
repository.  Update the references to reflect this.

PR-URL: #17987
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@mhdawson @MylesBorins
src: update make for new code coverage locations
bb9219b 
The files for code coverage are moving to the build
repository.  Update the references to reflect this.

PR-URL: #17987
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
mhdawson added a commit to mhdawson/io.js that referenced this pull request Jan 10, 2018
@mhdawson
src: fix code coverage cleanup
4764eb8 
In nodejs#17987 which updated
the location of the code coverage patches I missed a few
changes needed to properly clean up for code coverage.  Add
these.
@mhdawson mhdawson mentioned this pull request Jan 10, 2018
Closed
2 tasks
mhdawson added a commit that referenced this pull request Jan 16, 2018
@mhdawson
src: fix code coverage cleanup
8229fc0 
In #17987 which updated
the location of the code coverage patches I missed a few
changes needed to properly clean up for code coverage.  Add
these.

PR-URL: #18081
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Member

Should this land on lts? This lands cleanly on 8.x but will need a backport for 6.x

evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@mhdawson @evanlucas
src: fix code coverage cleanup
87e3d3d 
In #17987 which updated
the location of the code coverage patches I missed a few
changes needed to properly clean up for code coverage.  Add
these.

PR-URL: #18081
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Member

MylesBorins commented Feb 27, 2018 •
edited

ping re: backport

edit: should come with #18081

MylesBorins pushed a commit that referenced this pull request May 22, 2018
@mhdawson @MylesBorins
src: update make for new code coverage locations
2b941c6 
The files for code coverage are moving to the build
repository.  Update the references to reflect this.

PR-URL: #17987
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@mhdawson @MylesBorins
src: fix code coverage cleanup
a337e3a 
In #17987 which updated
the location of the code coverage patches I missed a few
changes needed to properly clean up for code coverage.  Add
these.

PR-URL: #18081
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@mhdawson @MylesBorins
src: update make for new code coverage locations
4521d77 
The files for code coverage are moving to the build
repository.  Update the references to reflect this.

PR-URL: #17987
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@mhdawson @MylesBorins
src: fix code coverage cleanup
f69ff7a 
In #17987 which updated
the location of the code coverage patches I missed a few
changes needed to properly clean up for code coverage.  Add
these.

PR-URL: #18081
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@mhdawson @rvagg
src: update make for new code coverage locations
0d2a720 
The files for code coverage are moving to the build
repository.  Update the references to reflect this.

PR-URL: #17987
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@mhdawson @rvagg
src: fix code coverage cleanup
5ea1492 
In #17987 which updated
the location of the code coverage patches I missed a few
changes needed to properly clean up for code coverage.  Add
these.

PR-URL: #18081
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson mhdawson deleted the fix-cov branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@XadillaX XadillaX XadillaX approved these changes

@maclover7 maclover7 maclover7 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@mhdawson @maclover7 @MylesBorins @jasnell @lpinca @TimothyGu @cjihrig @XadillaX @gireeshpunathil @nodejs-github-bot