Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.x] deps: cherry-pick c3458a8 from upstream V8 #18060

Closed
wants to merge 1 commit into from

Commits on Jan 11, 2018

  1. deps: cherry-pick c3458a8 from upstream V8

    Original commit message:
    
        [parser] Add new FunctionNameInferrer state before parsing param
    
        Create new state before parsing FormalParameter because we don't
        want to use any of the parameters as an inferred function name.
    
        Previously the stacktrace was:
          test.js:3: Error: boom
              throw new Error('boom');
              ^
          Error: boom
              at param (test.js:3:11)
              at test.js:4:5
              at test.js:6:3
    
        The stacktrace with this patch:
          test.js:3: Error: boom
              throw new Error('boom');
              ^
          Error: boom
              at test.js:3:11
              at test.js:4:5
              at test.js:6:3
    
        Bug: v8:6822, v8:6513
        Change-Id: Ifbadc660fc4e85248af405acd67c025f11662bd4
        Reviewed-on: https://chromium-review.googlesource.com/742657
        Reviewed-by: Adam Klein <adamk@chromium.org>
        Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
        Cr-Commit-Position: refs/heads/master@{nodejs#49042}
    
    Refs: v8/v8@c3458a8
    targos committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    9e4ddab View commit details
    Browse the repository at this point in the history