Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9.4.0 proposal #18069

Merged
merged 236 commits into from
Jan 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
236 commits
Select commit Hold shift + click to select a range
e58a5ca
net: remove Socket.prototype.listen
BridgeAR Dec 6, 2017
70588f7
test: simplify common.expectsError
BridgeAR Dec 11, 2017
bc7dc65
test: add test description to fs.readFile tests
davisjam Dec 7, 2017
1a84005
doc,test: mention Duplex support for TLS
addaleax Dec 11, 2017
7d1d739
src: fix inspector nullptr deref on abrupt exit
bnoordhuis Dec 8, 2017
ffe1ad6
deps: upgrade npm to 5.6.0
zkat Dec 7, 2017
e1f0846
src: introduce internal C++ SetImmediate() mechanism
addaleax Nov 18, 2017
e63e4a1
src: remove async_hooks destroy timer handle
addaleax Nov 18, 2017
df6acf9
src: remove tracking for exception arrow data
addaleax Nov 29, 2017
e276711
vm: never abort on caught syntax error
addaleax Nov 29, 2017
6bd0aff
src: remove unused variable in node_contextify
danbev Dec 6, 2017
23f4433
async_hooks: deprecate undocumented API
AndreasMadsen Nov 12, 2017
5514330
tls: use correct class name in deprecation message
addaleax Dec 9, 2017
75f99b7
src: minor cleanups to node_url.cc
addaleax Dec 5, 2017
9f1fe63
src: move url internals into anonymous namespace
addaleax Dec 5, 2017
ca3c255
src: make url host a proper C++ class
addaleax Dec 5, 2017
316da5e
src: use correct OOB check for IPv6 parsing
addaleax Dec 5, 2017
b379d8d
test: improve crypto/random.js coverage
Leko Dec 8, 2017
26025de
doc: replace ArrayBufferView in crypto
tniessen Dec 10, 2017
da44821
doc: clearify promisify behavior for bad arguments
ramsgoli Dec 10, 2017
d70e6dc
doc: note that randomBytes throws when passed null
tniessen Dec 10, 2017
5cd08d3
test: add unhandled rejection guard
babygoat Nov 23, 2017
6ba00b8
src: refactor and harden `ProcessEmitWarning()`
addaleax Dec 1, 2017
ed4d013
doc: correct pbkdf2 salt length recommendation
willclarktech Dec 7, 2017
6cb4cc2
test: fix flaky test-child-process-pass-fd
Trott Dec 11, 2017
584e74d
zlib: add ArrayBuffer support
Oct 6, 2017
3ad8cf1
tools: add lowercase-name-for-primitive eslint rule
starkwang Dec 9, 2017
977fb13
doc: import() is supported now
devsnek Nov 30, 2017
d879b63
src: make FSEventWrap/StatWatcher::Start more robust
TimothyGu Dec 3, 2017
41702ef
tls: unconsume stream on destroy
addaleax Dec 6, 2017
28ef3de
url: added space to class string of iterator objects
prohaejin Dec 9, 2017
7ed9e5d
src: remove `StreamResourc::Cast()`
addaleax Dec 9, 2017
008336c
src: minor refactoring to StreamBase writes
addaleax Dec 9, 2017
cc683bd
test: expand test-https-keep-alive-large-write
addaleax Dec 9, 2017
dfb9b5e
crypto: move node_crypto_clienthello-inl.h to cc
danbev Dec 11, 2017
5999a11
doc: include Daniel Bevenius as a TSC member
Trott Dec 13, 2017
bf0a7b6
process: fix coverage generation
evanlucas Dec 13, 2017
97eaaf9
test: remove unused disposed_ variable
danbev Dec 12, 2017
7008719
events: remove reaches into _events internals
apapirovski Nov 25, 2017
f16eca4
test: improve coverage for util.promisify
mithunsasidharan Dec 14, 2017
b1fd50a
test: remove literals that obscure assert messages
Trott Dec 13, 2017
0c6d9ae
src: fix compile warnings introduced in 73ad3f9bea
bnoordhuis Dec 13, 2017
6634dc4
src: fix -Wundefined-inline warnings
bnoordhuis Dec 13, 2017
7bf4102
win, build: fix without-intl option
bzoz Dec 11, 2017
b826528
test: fix flaky test-benchmark-misc
Trott Dec 14, 2017
eaa2d91
tools: simplify lowercase-name-for-primitive rule
cjihrig Dec 13, 2017
ed7f59a
url: added url fragment lookup table
Kimeiga Dec 8, 2017
ec443c3
assert: fix .throws operator
BridgeAR Dec 9, 2017
6d9b1e4
util: allow wildcards in NODE_DEBUG variable
TylerYang Dec 15, 2017
757e685
stream: remove `undefined` check
addaleax Dec 13, 2017
c3810e2
net: remove Socket.prototype.write
addaleax Dec 13, 2017
af1b340
doc: add C++ style comments to the style guide
Dec 11, 2017
9306de2
http: remove adapter frame from onParserExecute
bnoordhuis Dec 15, 2017
4b0c875
stream: add flow and buffer properties to streams
calvinmetcalf May 16, 2017
bdddb82
test: check socketOnDrain where needPause is false
Leko Dec 13, 2017
a9d83ce
test: change callback function to arrow function
skanamaru Dec 15, 2017
d48a1b9
test: change callback function to arrow function
you12724 Dec 15, 2017
bc45354
test: change callback function to arrow function
routerman Dec 15, 2017
6f520e3
src: remove unused strings from env.h
addaleax Dec 13, 2017
d84d9be
src: rename `On*` -> `Emit*` for stream callbacks
addaleax Dec 15, 2017
c24b4dd
doc: remove extra whitespace in module docs
watson Dec 16, 2017
712848b
doc: change eventName type annotations
aprilwebster Dec 13, 2017
a93ed5c
src: replace SetAccessor w/ SetAccessorProperty
jure Dec 13, 2017
e059bc5
doc: change "Node.js style cb" to "error-first cb"
ramsgoli Dec 12, 2017
373d5df
test: coverage for emitExperimentalWarning
mithunsasidharan Dec 13, 2017
d1af106
doc: add countdown module to writing tests guide
Bamieh Dec 12, 2017
46f8a9e
test: update test-http-content-length to use countdown
Bamieh Dec 12, 2017
d9190c1
test: Use countdown in test file
sreepurnajasti Dec 13, 2017
c5c4a53
stream: rm {writeable/readable}State.length
calvinmetcalf May 5, 2017
305dd56
test: add test for postmortem metadata validation
cjihrig Dec 14, 2017
444362e
doc: improve documentation.md
Fishrock123 Dec 15, 2017
d193431
doc: fix fs.existsSync description
Fishrock123 Dec 15, 2017
68722fd
doc: adjust TTY wording & add inter-doc links
Fishrock123 Dec 15, 2017
ecbc70f
doc: not all example code can be run without 1:1
Fishrock123 Dec 15, 2017
861f6ad
doc: some fs doc improvements
jasnell Dec 15, 2017
79a2833
n-api: fix memory leak in napi_async_destroy()
Dec 17, 2017
ed9f2fe
doc: improve release guide
evanlucas Dec 14, 2017
dcfe840
doc: edit CONTRIBUTING.md preamble
Trott Dec 15, 2017
dd9d07c
doc: remove unused link definition
maclover7 Dec 18, 2017
dbc554a
doc: fix typo in child_process.md
Trott Dec 18, 2017
206c4f8
doc: fix typo in README.md
starkwang Dec 18, 2017
c982494
doc: remove duplicate the from onboarding.md
sreepurnajasti Dec 18, 2017
d6c5885
src: remove nonexistent method from header file
addaleax Dec 19, 2017
5a9694e
test: change callback function to arrow function
rt33 Dec 18, 2017
7d03567
crypto: remove unused header in clienthello.h
danbev Dec 19, 2017
6531401
tools: add number-isnan rule
maclover7 Dec 11, 2017
f18d826
http2: simplify onSelectPadding
addaleax Dec 17, 2017
0573c0f
console: make error handling engine agnostic
BridgeAR Dec 16, 2017
41e2bb1
console: make variables and checks stricter
BridgeAR Dec 16, 2017
27227cf
benchmark: refactor console benchmark
BridgeAR Dec 16, 2017
28283ef
console: order functions and remove \n\n
BridgeAR Dec 16, 2017
b1a8ac7
doc: remove old console note
BridgeAR Dec 16, 2017
99c62cc
src: remove unused async hooks methods
addaleax Dec 19, 2017
7153434
crypto: reuse variable instead of reevaluation
tniessen Dec 18, 2017
dd14004
test: fix typo in test-inspector-cluster-port-clash.js
Trott Dec 20, 2017
74a5bba
net: remove ADDRCONFIG DNS hint on Windows
bzoz Dec 13, 2017
6d15185
test: increase pbkdf2 test coverage
Leko Dec 18, 2017
c953967
test: increase diffie-hellman test coverage
Leko Dec 18, 2017
60ae556
test: refactor test-net-connect-buffer
addaleax Dec 13, 2017
b6d2090
doc: improve fs api descriptions
evanlucas Dec 14, 2017
1d935a0
doc: instructions on how to make membership public
mhdawson Dec 14, 2017
2aa75a1
src: remove redundant `JSStream::DoAfterWrite`
addaleax Dec 16, 2017
dce7d7f
test: refactor test-repl-definecommand
Trott Dec 20, 2017
112b655
test: improve flaky test-listen-fd-ebadf.js
Trott Dec 20, 2017
b44f245
tls: comment about old-style errors
Xavier-J-Ortiz Dec 19, 2017
c328e58
doc: improve module.builtinModules documentation
watson Dec 16, 2017
f79d2ef
test: use valid authentication tag length
tniessen Dec 9, 2017
d387c17
crypto: warn on invalid authentication tag length
tniessen Dec 9, 2017
6994559
doc: removed extra explanation in api/buffer.md
WaleedAshraf Dec 20, 2017
e9ace7e
test: do not open fixture files for writing
Trott Dec 21, 2017
8f3b2d7
deps: V8: cherry-pick ac0fe8ec from upstream
ofrobots Dec 15, 2017
7ef876d
tools: fix man pages linking regex
DiegoRBaquero Dec 18, 2017
06862f0
test: do not open fixture files for writing
Trott Dec 21, 2017
6cc622f
vm: allow modifying context name in inspector
TimothyGu Dec 17, 2017
541d189
doc: use american spelling as per style guide
sreepurnajasti Dec 22, 2017
d4666d0
doc: require CI status indicator in PRs
seishun Nov 20, 2017
fe1f67f
doc: mark DEP0002 as end of life
maclover7 Dec 22, 2017
2d61b9e
lib, src: use process.config instead of regex
maclover7 Dec 21, 2017
ded097a
test: use common module API in test-child-process-exec-stdout-stderr-…
sreepurnajasti Dec 19, 2017
2d11f6b
doc: add starkwang to collaborators
starkwang Dec 24, 2017
14eb97e
benchmark: make temp file path configurable
Trott Dec 21, 2017
3b2d8cb
module: print better message on esm import error
targos Dec 20, 2017
fea5d08
test: fix flaky test-benchmark-fs
Trott Dec 24, 2017
0843ed6
async_hooks: use CHECK instead of throwing error
maclover7 Dec 23, 2017
ee4cbac
test: fix unreliable async-hooks/test-signalwrap
Trott Dec 22, 2017
ca35d08
test: remove ambiguous error messages from test_error
nadrane Dec 21, 2017
9110654
test: remove undefined function
Trott Dec 23, 2017
2d07243
tools: autofixer for lowercase-name-for-primitive
shobhitchittora Dec 17, 2017
59711ae
doc: update AUTHORS list
BridgeAR Dec 21, 2017
a63d3c5
doc: update formatting to fit our 80 chars rule
BridgeAR Dec 17, 2017
26fbb0f
doc: use consistent new lines
BridgeAR Dec 17, 2017
1be0086
doc: use dashes instead of asterisks
BridgeAR Dec 17, 2017
8b666d6
test: reduce scope of variable in common module
Trott Dec 22, 2017
8d4fca3
inspector: make Coverity happy
eugeneo Dec 13, 2017
b89cda4
tools: fix AttributeError: __exit__ on Python 2.6
dkasyanov Dec 13, 2017
f82439b
http: add rawPacket in err of `clientError` event
XadillaX Dec 14, 2017
a329cf6
perf_hooks: refactor internals
jasnell Dec 21, 2017
e69ea78
tls: fix SNICallback without .server option
addaleax Dec 23, 2017
1dd859d
test: refactor test-tls-securepair-fiftharg
addaleax Dec 23, 2017
1b8d3ec
crypto: add ocsp_request ClientHelloParser::Reset
danbev Dec 11, 2017
0aa403b
buffer: optimize readDouble and readFloat methods
bnoordhuis Dec 20, 2017
411e772
test: make test-tls-invoke-queued use public API
addaleax Dec 25, 2017
cb127de
doc: improve module.builtinModules text
Trott Dec 25, 2017
2c9dab3
doc: use my legal name in README
TimothyGu Dec 28, 2017
f25bab5
test: fix flaky test-benchmark-fs
Trott Dec 27, 2017
9fc9bb1
doc: fix typo
tniessen Dec 28, 2017
b15f029
doc: fs doc improvements
jasnell Dec 22, 2017
b1bc768
readline: refactor filter() callback
Trott Dec 25, 2017
2759709
test: replace map() with forEach() where appropriate
Trott Dec 25, 2017
4391ea4
tools: enable array-callback-return ESLint rule
Trott Dec 25, 2017
4850c87
doc: doc imitating the old behavior of http.Server.keepAliveTimeout
TysonAndre-tmg Dec 13, 2017
2cc5053
repl: fix coloring of `process.versions`
bnoordhuis Dec 25, 2017
421eb75
test: improve to use template string
sreepurnajasti Dec 28, 2017
c91a7c0
tools: add check for using process.binding crypto
danbev Dec 26, 2017
ef533c9
test: add hasCrypto when using binding('crypto')
danbev Dec 26, 2017
2f4da8b
test: use countdown in test file
sreepurnajasti Dec 27, 2017
5df8c76
deps: update nghttp2 to 1.29.0
jasnell Dec 28, 2017
fb640c6
timers: remove domain enter and exit
apapirovski Dec 27, 2017
66c1a03
gitignore: ignore *.VC.db files
tniessen Dec 28, 2017
181b897
doc: fix duplicate words & spellings in docs
sreepurnajasti Dec 31, 2017
3927c6f
test: improve readability of some crypto tests
tniessen Dec 28, 2017
658bdb3
doc: remove duplicate words in API docs
tniessen Jan 1, 2018
d2b1601
doc: replace wrong U+00A0 by common spaces
vsemozhetbyt Jan 1, 2018
2f7030d
doc: add references to PR communication articles
Dec 28, 2017
312ad06
doc: fix spelling of contributors
Trott Dec 31, 2017
240121e
doc: improve alt text
Trott Dec 31, 2017
a702fcb
doc: copy-edit COLLABORATOR_GUIDE.md
Trott Dec 31, 2017
2d857ed
build: remove duplicate async-hooks and known_issues test runs
Trott Dec 29, 2017
16fbd57
doc: remove non-style information from style guide
Trott Dec 25, 2017
54cf75d
doc: fix typos in CONTRIBUTING.md
Trott Jan 1, 2018
14499f8
doc: improve PR-review paragraph in CONTRIBUTING.md
Trott Jan 1, 2018
3fd6581
doc: remove x86 from os.arch() options
gibfahn Dec 28, 2017
445c911
doc: edit for concision
Trott Dec 28, 2017
294c5f4
doc: improve security section of README.md
Trott Jan 1, 2018
87b336a
src: remove unused GetHostByNameWrap
bnoordhuis Dec 25, 2017
98dc554
src: inline HostentToAddresses()
bnoordhuis Dec 25, 2017
6efef47
doc: move joshgav to TSC emeriti list
Trott Jan 2, 2018
63c23a1
benchmark: fix timeout in write-stream-throughput
apapirovski Jan 3, 2018
3cc9882
test: fix flaky test-resolve-async
apapirovski Jan 3, 2018
f87a1a6
test: simplify test-buffer-slice.js
starkwang Jan 3, 2018
591dd4e
test: fix crypto test case to use correct encoding
tniessen Jan 2, 2018
7998058
test: fix flaky http-writable-true-after-close
apapirovski Jan 3, 2018
3399e8a
test: fix flaky test-pipe-unref
apapirovski Jan 2, 2018
8e1011f
http: remove duplicate export
evanlucas Jan 4, 2018
8806e54
test: fix flaky test-http-highwatermark
apapirovski Jan 2, 2018
51eab4b
test: rename regression tests
tniessen Jan 2, 2018
d066db7
cluster: support windowsHide option for workers
toddwong Dec 1, 2017
adc59a3
tools: host remark-preset-lint-node in-tree
maclover7 Dec 3, 2017
224033d
build: put .PHONY directly before its target
oantoro Jan 3, 2018
b313e81
test: fix flaky test-http-pipeline-flood
apapirovski Jan 3, 2018
72ed11a
doc: move matthewloring to emeriti
Trott Jan 5, 2018
83c725d
doc: updates examples to use NULL
mhdawson Jan 5, 2018
7e68080
src: add optional keep-alive object to SetImmediate
addaleax Nov 21, 2017
d06ad0d
http2: don't call into JS from GC
addaleax Nov 21, 2017
30e75e6
http2: only schedule write when necessary
addaleax Nov 21, 2017
f699a74
http2: be sure to destroy the Http2Stream
jasnell Nov 27, 2017
5abb609
http2: cleanup Http2Stream/Http2Session destroy
jasnell Dec 12, 2017
9592691
http2: remove redundant write indirection
addaleax Dec 17, 2017
bfc7e01
http2: refactor outgoing write mechanism
addaleax Dec 17, 2017
3a6b2ad
http2: convert Http2Settings to an AsyncWrap
jasnell Dec 18, 2017
e3c567f
http2: fix compiling with `--debug-http2`
addaleax Dec 25, 2017
b8deb75
http2: keep session objects alive during Http2Scope
addaleax Dec 25, 2017
1b7ce1e
http2: implement ref() and unref() on client sessions
kjin Dec 11, 2017
a003ded
http2: remove duplicate words in comments
tniessen Jan 1, 2018
06aaaa8
http2: perf_hooks integration
jasnell Dec 20, 2017
e7a727e
http2: strictly limit number on concurrent streams
jasnell Nov 21, 2017
9ad7a9a
http2: add altsvc support
jasnell Dec 29, 2017
3997617
tls: set servername on client side too
jasnell Jan 1, 2018
2b6a5d9
http2: add initial support for originSet
jasnell Jan 1, 2018
79d3198
http2: add aligned padding strategy
jasnell Jan 1, 2018
f17a5b9
http2: properly handle already closed stream error
jasnell Jan 2, 2018
46f39b5
doc: add docs for common/http2.js utility
jasnell Jan 2, 2018
f9c84c5
src: silence http2 -Wunused-result warnings
cjihrig Jan 2, 2018
865da60
http2: implement maxSessionMemory
jasnell Jan 3, 2018
6839283
http2: verify that a dependency cycle may exist
jasnell Jan 3, 2018
43ac36c
doc: grammar fixes in http2.md
Trott Jan 4, 2018
6a67dfd
http2: verify flood error and unsolicited frames
jasnell Jan 3, 2018
1181ff7
doc: correct spelling
sreepurnajasti Dec 29, 2017
0e116a0
perf_hooks: fix scheduling regression
apapirovski Jan 9, 2018
f148556
fs: guarantee order of callbacks in ws.close
mcollina Jan 5, 2018
0ad783a
doc: fix link for https api change
MylesBorins Dec 12, 2017
aa75190
src: remove duplicate words in comments
tniessen Jan 1, 2018
3bcdb3b
doc: fix code nits in common/README
vsemozhetbyt Jan 4, 2018
b593d94
doc: re-alphabetise sections in common/README.md
vsemozhetbyt Jan 4, 2018
7bf6be0
trace_events: stop tracing agent in process.exit()
AndreasMadsen Jan 5, 2018
bb9219b
src: update make for new code coverage locations
mhdawson Jan 4, 2018
d93b476
build: document targets in the Makefile
joyeecheung Nov 12, 2017
3623cf7
doc: add guide on maintaining build files
joyeecheung Nov 12, 2017
4dacff7
tools: do not override V8's gitignore
hashseed Jan 5, 2018
b817a8a
lib: enable dot-notation eslint rule
apapirovski Jan 5, 2018
ef31701
doc: compact eslint directives in common/README
vsemozhetbyt Jan 4, 2018
1ad7df6
http2: use aliased buffer for perf stats, add stats
jasnell Jan 6, 2018
ffc2659
doc: fix incorrect argument type in fs.readSync
belochub Jan 6, 2018
43fbc39
deps: cherry-pick 50f7455 from upstream V8
targos Dec 21, 2017
3831d87
repl: show lexically scoped vars in tab completion
targos Oct 29, 2017
7aefa40
2019-01-10 Version 9.4.0 (Current)
MylesBorins Jan 10, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ rules:
# Best Practices
# http://eslint.org/docs/rules/#best-practices
accessor-pairs: error
array-callback-return: error
dot-location: [error, property]
eqeqeq: [error, smart]
no-fallthrough: error
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ _UpgradeReport_Files/
ipch/
*.sdf
*.opensdf
*.VC.db
*.VC.opendb
.vs/
.vscode/
Expand Down Expand Up @@ -118,3 +119,6 @@ icu_config.gypi
deps/uv/.github/
deps/uv/docs/code/
deps/uv/docs/src/guide/

# do not override V8's .gitignore
!deps/v8/**
3 changes: 3 additions & 0 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,8 @@ Kathy Truong <kathy.yvy.truong@gmail.com> k3kathy <kathy.yvy.truong@gmail.com>
Kazuyuki Yamada <tasogare.pg@gmail.com>
Keith M Wesolowski <wesolows@joyent.com> <wesolows@foobazco.org>
Kelsey Breseman <ifoundthemeaningoflife@gmail.com>
Khaidi Chu <admin@xcoder.in> XadillaX <admin@xcoder.in>
Khaidi Chu <admin@xcoder.in> <i@2333.moe>
Kiyoshi Nomo <tokyoincidents.g@gmail.com> kysnm <tokyoincidents.g@gmail.com>
Koichi Kobayashi <koichik@improvement.jp>
Kris Kowal <kris.kowal@cixar.com>
Expand Down Expand Up @@ -264,6 +266,7 @@ Roman Klauke <romaaan.git@gmail.com> <romankl@users.noreply.github.com>
Roman Reiss <me@silverwind.io>
Ron Korving <ron@ronkorving.nl> <rkorving@wizcorp.jp>
Ron Korving <ron@ronkorving.nl> ronkorving <ron@ronkorving.nl>
Ruben Bridgewater <ruben@bridgewater.de> <ruben.bridgewater@fintura.de>
Russell Dempsey <sgtpooki@gmail.com> <SgtPooki@gmail.com>
Ryan Dahl <ry@tinyclouds.org>
Ryan Emery <seebees@gmail.com>
Expand Down
34 changes: 31 additions & 3 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ HUANG Wei <grubbyfans@gmail.com>
DC <dcposch@dcpos.ch>
Daniel Turing <mail@danielturing.com>
Julie Pagano <julie.pagano@gmail.com>
Ruben Bridgewater <ruben.bridgewater@fintura.de>
Ruben Bridgewater <ruben@bridgewater.de>
Felix Becker <felix.b@outlook.com>
Igor Klopov <igor@klopov.com>
Tsarevich Dmitry <dimhotepus@users.noreply.github.com>
Expand Down Expand Up @@ -1493,7 +1493,7 @@ Sreepurna Jasti <sreepurna.jasti@gmail.com>
Rafael Fragoso <rafaelfragosom@gmail.com>
Andrei Cioromila <andrei.cioromila@gmail.com>
Frank Lanitz <frank@frank.uvena.de>
XadillaX <admin@xcoder.in>
Khaidi Chu <admin@xcoder.in>
Akshay Iyer <c.m.akshay.iyer@gmail.com>
Rick Bullotta <RickBullotta@users.noreply.github.com>
Rajaram Gaunker <zimbabao@gmail.com>
Expand Down Expand Up @@ -1532,7 +1532,6 @@ Dan Homola <dan.homola@hotmail.cz>
cornholio <0@mcornholio.ru>
Tamás Hódi <tamas.hodi@risingstack.com>
DuanPengfei <2459714173@qq.com>
Ruben Bridgewater <ruben@bridgewater.de>
Lakshmi Swetha Gopireddy <lakshmiswethagopireddy@gmail.com>
Rob Wu <rob@robwu.nl>
Steven Winston <swinston100@hotmail.com>
Expand Down Expand Up @@ -2036,5 +2035,34 @@ Hannes Magnusson <hannes.magnusson@creditkarma.com>
ChungNgoops <mr.mvagusta@gmail.com>
Jose M. Palacios Diaz <jmpd1988@gmail.com>
hmammedzadeh <hasan.mammed-zadeh@commercetools.de>
IHsuan <frostyjoan0829@livemail.tw>
Francisco Gerardo Neri Andriano <on_neri@hotmail.com>
Shilo Mangam <smangam@gmail.com>
idandagan1 <idandagan1@gmail.com>
Cameron Moorehead <hello@cameronmoorehead.com>
TomerOmri <tomer92@gmail.com>
Collins Abitekaniza <abtcolns@gmail.com>
Federico Kauffman <fede.kau@gmail.com>
Benno Fünfstück <benno.fuenfstueck@gmail.com>
Ram Goli <ramsgoli@gmail.com>
babygoat <babygoat1124@gmail.com>
Will Clark <willclarktech@users.noreply.github.com>
Jem Bezooyen <jem@hipmedia.ca>
Haejin Jo <professionalhaejin@gmail.com>
Hakan Kimeiga <hak7alp@gmail.com>
Tyler <tyler.z.yang@gmail.com>
Shinya Kanamaru <mn131bb@gmail.com>
you12724 <you12724@gmail.com>
routerman <h.okano.looz@gmail.com>
April Webster <awebster@us.ibm.com>
Jure Triglav <juretriglav@gmail.com>
alnyan <qShadowp@gmail.com>
rt33 <rt33@lastcycle.com>
Ulmanb <barulman@gmail.com>
xortiz <xavier.ortiz.ch@gmail.com>
Waleed Ashraf <waleedashraf@outlook.com>
Mir Mufaqam Ali <mannanali413@gmail.com>
Nicholas Drane <nicholasdrane@gmail.com>
Shobhit Chittora <chittorashobhit@gmail.com>

# Generated by tools/update-authors.sh
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V9.md#9.3.0">9.3.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V9.md#9.4.0">9.4.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V9.md#9.3.0">9.3.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V9.md#9.2.1">9.2.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V9.md#9.2.0">9.2.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V9.md#9.1.0">9.1.0</a><br/>
Expand Down
45 changes: 25 additions & 20 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

* [Issues and Pull Requests](#issues-and-pull-requests)
- [Managing Issues and Pull Requests](#managing-issues-and-pull-requests)
- [Welcoming First-Time Contributiors](#welcoming-first-time-contributiors)
- [Welcoming First-Time Contributors](#welcoming-first-time-contributors)
- [Closing Issues and Pull Requests](#closing-issues-and-pull-requests)
* [Accepting Modifications](#accepting-modifications)
- [Code Reviews and Consensus Seeking](#code-reviews-and-consensus-seeking)
Expand Down Expand Up @@ -33,7 +33,7 @@
- [How is an LTS release cut?](#how-is-an-lts-release-cut)

This document contains information for Collaborators of the Node.js
project regarding maintaining the code, documentation, and issues.
project regarding managing the project's code, documentation, and issue tracker.

Collaborators should be familiar with the guidelines for new
contributors in [CONTRIBUTING.md](./CONTRIBUTING.md) and also
Expand All @@ -52,11 +52,11 @@ may also notify other qualified parties for more input on an issue
or a pull request.
[See "Who to CC in issues"](./doc/onboarding-extras.md#who-to-cc-in-issues)

### Welcoming First-Time Contributiors
### Welcoming First-Time Contributors

Courtesy should always be shown to individuals submitting issues and pull
requests to the Node.js project. Be welcoming to first-time contributors,
identified by the GitHub ![badge](./doc/first_timer_badge.png) badge.
identified by the GitHub ![First-time contributor](./doc/first_timer_badge.png) badge.

For first-time contributors, check if the commit author is the same as the
pull request author, and ask if they have configured their git
Expand Down Expand Up @@ -116,6 +116,11 @@ oppose the PR, it can be landed. Where there is disagreement among TSC members
or objections from one or more Collaborators, `semver-major` pull requests
should be put on the TSC meeting agenda.

#### Helpful resources

* How to respectfully and usefully review code, part [one](https://mtlynch.io/human-code-reviews-1/) and [two](https://mtlynch.io/human-code-reviews-2/)
* [How to write a positive code review](https://css-tricks.com/code-review-etiquette/)

### Waiting for Approvals

Before landing pull requests, sufficient time should be left for input
Expand All @@ -142,6 +147,7 @@ test should *fail* before the change, and *pass* after the change.
All pull requests that modify executable code should be subjected to
continuous integration tests on the
[project CI server](https://ci.nodejs.org/).
The pull request should have a CI status indicator if possible.

#### Useful CI Jobs

Expand Down Expand Up @@ -200,11 +206,10 @@ Node.js API are internal:
- Any native C/C++ APIs/ABIs exported by the Node.js `*.h` header files that
are hidden behind the `NODE_WANT_INTERNALS` flag are internal.

Exception to each of these points can be made if use or behavior of a given
internal API can be demonstrated to be sufficiently relied upon by the Node.js
ecosystem such that any changes would cause too much breakage. The threshold
for what qualifies as too much breakage is to be decided on a case-by-case
basis by the TSC.
Exceptions can be made if use or behavior of a given internal API can be
demonstrated to be sufficiently relied upon by the Node.js ecosystem such that
any changes would cause too much breakage. The threshold for what qualifies as
too much breakage is to be decided on a case-by-case basis by the TSC.

If it is determined that a currently undocumented object, property, method,
argument, or event *should* be documented, then a pull request adding the
Expand Down Expand Up @@ -243,14 +248,14 @@ properties to an options argument) are semver-minor changes.

#### Breaking Changes and Deprecations

With a few notable exceptions outlined below, when backwards incompatible
changes to a *Public* API are necessary, the existing API *must* be deprecated
*first* and the new API either introduced in parallel or added after the next
major Node.js version following the deprecation as a replacement for the
deprecated API. In other words, as a general rule, existing *Public* APIs
*must not* change (in a backwards incompatible way) without a deprecation.
With a few exceptions outlined below, when backward-incompatible changes to a
*Public* API are necessary, the existing API *must* be deprecated *first* and
the new API either introduced in parallel or added after the next major Node.js
version following the deprecation as a replacement for the deprecated API. In
other words, as a general rule, existing *Public* APIs *must not* change (in a
backward-incompatible way) without a deprecation.

Exception to this rule is given in the following cases:
Exceptions to this rule may be made in the following cases:

* Adding or removing errors thrown or reported by a Public API;
* Changing error messages;
Expand Down Expand Up @@ -351,7 +356,7 @@ recommended but not required.
### Deprecations

_Deprecation_ refers to the identification of Public APIs that should no longer
be used and that may be removed or modified in non-backwards compatible ways in
be used and that may be removed or modified in backward-incompatible ways in
a future major release of Node.js. Deprecation may be used with internal APIs if
there is expected impact on the user community.

Expand Down Expand Up @@ -491,7 +496,7 @@ Check and re-review the changes:
$ git diff upstream/master
```

Check number of commits and commit messages:
Check the number of commits and commit messages:

```text
$ git log upstream/master...master
Expand Down Expand Up @@ -652,7 +657,7 @@ commit final.
#### What is LTS?

Long Term Support (often referred to as *LTS*) guarantees application developers
a 30 month support cycle with specific versions of Node.js.
a 30-month support cycle with specific versions of Node.js.

You can find more information
[in the full release plan](https://github.com/nodejs/Release#release-plan).
Expand All @@ -665,7 +670,7 @@ certain performance improvements that can be demonstrated to not break existing
applications. Semver-minor changes are only permitted if required for bug fixes
and then only on a case-by-case basis with LTS WG and possibly Technical
Steering Committee (TSC) review. Semver-major changes are permitted only if
required for security related fixes.
required for security-related fixes.

Once a Current branch moves into Maintenance mode, only **critical** bugs,
**critical** security fixes, and documentation updates will be permitted.
Expand Down
32 changes: 14 additions & 18 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
# Contributing to Node.js

Contributions to Node.js may come in many forms. Some contribute code changes,
others contribute docs, others help answer questions from users, help keep the
infrastructure running, or seek out ways of advocating for Node.js users of all
types.
Contributions to Node.js include code, documentation, answering user questions,
running the project's infrastructure, and advocating for all types of Node.js
users.

The Node.js project welcomes all contributions from anyone willing to work in
good faith both with other contributors and with the community. No contribution
is too small and all contributions are valued.
good faith with other contributors and the community. No contribution is too
small and all contributions are valued.

This guide details the basic steps for getting started contributing to the
Node.js project's core `nodejs/node` GitHub Repository and describes what to
expect throughout each step of the process.
This guide explains the process for contributing to the Node.js project's core
`nodejs/node` GitHub Repository and describes what to expect at each step.

* [Code of Conduct](#code-of-conduct)
* [Bad Actors](#bad-actors)
Expand Down Expand Up @@ -201,9 +199,8 @@ functional guidelines of the Node.js project.

## Pull Requests

Pull Requests are the way in which concrete changes are made to the code,
documentation, dependencies, and tools contained with the `nodejs/node`
repository.
Pull Requests are the way concrete changes are made to the code, documentation,
dependencies, and tools contained in the `nodejs/node` repository.

There are two fundamental components of the Pull Request process: one concrete
and technical, and one more process oriented. The concrete and technical
Expand Down Expand Up @@ -605,12 +602,11 @@ your name on it. Congratulations and thanks for your contribution!
All Node.js contributors who choose to review and provide feedback on Pull
Requests have a responsibility to both the project and the individual making the
contribution. Reviews and feedback must be helpful, insightful, and geared
towards improving the contribution as opposed to simply blocking it or
stopping it. If there are reasons why you feel the PR should not land, explain
what those are. Do not expect to be able to block a Pull Request from advancing
simply because you say "No" without giving an explanation. It is also important
to be open to having your mind changed, and to being open to working with the
contributor to make the Pull Request better.
towards improving the contribution as opposed to simply blocking it. If there
are reasons why you feel the PR should not land, explain what those are. Do not
expect to be able to block a Pull Request from advancing simply because you say
"No" without giving an explanation. Be open to having your mind changed. Be open
to working with the contributor to make the Pull Request better.

Reviews that are dismissive or disrespectful of the contributor or any other
reviewers are strictly counter to the [Code of Conduct][].
Expand Down
21 changes: 21 additions & 0 deletions CPP_STYLE_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* [Formatting](#formatting)
* [Left-leaning (C++ style) asterisks for pointer declarations](#left-leaning-c-style-asterisks-for-pointer-declarations)
* [C++ style comments](#c-style-comments)
* [2 spaces of indentation for blocks or bodies of conditionals](#2-spaces-of-indentation-for-blocks-or-bodies-of-conditionals)
* [4 spaces of indentation for statement continuations](#4-spaces-of-indentation-for-statement-continuations)
* [Align function arguments vertically](#align-function-arguments-vertically)
Expand Down Expand Up @@ -33,6 +34,26 @@ these rules:

`char* buffer;` instead of `char *buffer;`

## C++ style comments

Use C++ style comments (`//`) for both single-line and multi-line comments.
Comments should also start with uppercase and finish with a dot.

Examples:

```c++
// A single-line comment.

// Multi-line comments
// should also use C++
// style comments.
```

The codebase may contain old C style comments (`/* */`) from before this was the
preferred style. Feel free to update old comments to the preferred style when
working on code in the immediate vicinity or when changing/improving those
comments.

## 2 spaces of indentation for blocks or bodies of conditionals

```c++
Expand Down
Loading