test: added input validation test for fchmod #18217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
jasnell
approved these changes
Jan 18, 2018
cjihrig
approved these changes
Jan 18, 2018
|
Hey look @cjihrig ... @lucamaraschi submitted a test case! How many more does he have to go ;-) |
|
@jasnell if my math is right, 90 once this lands. |
BridgeAR
approved these changes
Jan 18, 2018
addaleax
approved these changes
Jan 18, 2018
addaleax
added
author ready
|
CI complains about a syntax error: |
jasnell
reviewed
Jan 18, 2018
test/parallel/test-fs-fchmod.js
Outdated
| // Check for mode values range | ||
| const modeUpperBoundaryValue = 0o777; | ||
| common.mustCall(() => fs.fchmod(1, modeUpperBoundaryValue); | ||
| common.mustCall(() => fs.fchmodSync(1, modeUpperBoundaryValue); |
There was a problem hiding this comment.
nit: missing parens at the end of both of these lines.
lucamaraschi
force-pushed
the
test-fs-fchmod
branch
from
572c760
to
b16a6e5
Compare
targos
reviewed
Jan 20, 2018
test/parallel/test-fs-fchmod.js
Outdated
| // Check for mode values range | ||
| const modeUpperBoundaryValue = 0o777; | ||
| common.mustCall(() => fs.fchmod(1, modeUpperBoundaryValue)); | ||
| common.mustCall(() => fs.fchmodSync(1, modeUpperBoundaryValue)); |
There was a problem hiding this comment.
Is it me or something is missing? The function returned by common.mustCall is never called, so I expect the test to fail.
There was a problem hiding this comment.
Good point. And neither of these two entries should require being wrapped in a mustCall.
Added a test to ensure input validation for FD and mode for fs.fchmod. Removed check for values lower than 0 for `mode` as it's already checked by `validateUint32`.
lucamaraschi
force-pushed
the
test-fs-fchmod
branch
from
b16a6e5
to
61d47f2
Compare
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 6, 2018
Added a test to ensure input validation for FD and mode for fs.fchmod. Removed check for values lower than 0 for `mode` as it's already checked by `validateUint32`. PR-URL: nodejs#18217 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 075eef5 @lucamaraschi you are very much behind with those tests! |
|
Should this be backported to |
This was referenced Apr 7, 2024
This was referenced Apr 7, 2024
This was referenced Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test to ensure input validation for FD and mode for fs.fchmod.
Removed check for values lower than 0 for
modeas it's already checkedby
validateUint32.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, fs