Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: remove unreachable code #18239

Closed
wants to merge 2 commits into from
Closed

stream: remove unreachable code #18239

wants to merge 2 commits into from

Commits on Jan 18, 2018

  1. stream: remove unreachable code 

    To avoid a function call `BufferList.prototype.concat()` is not called
when there is only a buffer in the list. That buffer is instead
accessed directly.
    @lpinca
    lpinca committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    5593b51 View commit details
    Browse the repository at this point in the history

  2. test: use correct size in test-stream-buffer-list 

    The `n` argument of `BufferList.prototype.concat()` is not the number
of `Buffer` instances in the list, but their total length when
concatenated.
    @lpinca
    lpinca committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    4461fa5 View commit details
    Browse the repository at this point in the history