[v6.x backport] test: improve flaky test-listen-fd-ebadf.js #18362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find an invalid file descriptor rather than assuming 42 will be invalid. PR-URL: nodejs#17797 Fixes: nodejs#17762 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2 tasks
BridgeAR
approved these changes
Jan 31, 2018
|
landed in b6a2b6e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find an invalid file descriptor rather than assuming 42 will be invalid.
PR-URL: #17797
Fixes: #17762
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Khaidi Chu i@2333.moe
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test