Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test assertions and comments in napi tests #18414

Closed
wants to merge 4 commits into from
Closed

test: refactor test assertions and comments in napi tests #18414

wants to merge 4 commits into from

Conversation

nbdaaron
Copy link
Contributor

Change assert.ok() to assert.notStrictEquals() where appropriate and change some functions to arrow functions.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jan 27, 2018
@nbdaaron nbdaaron changed the title test: refactor test assertions and comments in napi tests. test: refactor test assertions and comments in napi tests Jan 27, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/12785/

lpinca
lpinca approved these changes Jan 28, 2018
View reviewed changes
test/addons-napi/test_general/test.js Outdated
assert.ok(test_general.testGetPrototype(baseObject) !==
test_general.testGetPrototype(extendedObject),
'Prototypes for base and extended should be different');
//Prototypes for base and extended should be different.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please add a space after //?

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v4.x and removed dont-land-on-v4.x labels Jan 31, 2018
contact-natz
contact-natz reviewed Jan 31, 2018
View reviewed changes
Copy link

@contact-natz contact-natz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@contact-natz
Copy link

contact-natz commented Jan 31, 2018 •
edited by BridgeAR
Loading

[Moderated]

contact-natz
contact-natz suggested changes Jan 31, 2018
View reviewed changes
Copy link

@contact-natz contact-natz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 31, 2018
@nbdaaron @BridgeAR
n-api: change assert ok check to notStrictEqual.
6e312c5 
PR-URL: nodejs#18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in 6e312c5

@BridgeAR BridgeAR closed this Jan 31, 2018
@hooliganznat
Copy link

👍👍👍

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@nbdaaron @MylesBorins
n-api: change assert ok check to notStrictEqual.
c8b92e2 
PR-URL: #18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@nbdaaron @MylesBorins
n-api: change assert ok check to notStrictEqual.
9ee15fa 
PR-URL: #18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@nbdaaron @MylesBorins
n-api: change assert ok check to notStrictEqual.
a07cd06 
PR-URL: #18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
@nbdaaron
n-api: change assert ok check to notStrictEqual.
021e4a4 
PR-URL: nodejs#18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@nbdaaron
n-api: change assert ok check to notStrictEqual.
0fd8ceb 
PR-URL: nodejs#18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@nbdaaron @MylesBorins
n-api: change assert ok check to notStrictEqual.
d9df8cf 
Backport-PR-URL: #19447
PR-URL: #18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
@nbdaaron @MylesBorins
n-api: change assert ok check to notStrictEqual.
af655f5 
Backport-PR-URL: #19265
PR-URL: #18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@nbdaaron @MayaLekova
n-api: change assert ok check to notStrictEqual.
483eeb5 
PR-URL: nodejs#18414
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contact-natz contact-natz contact-natz requested changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nbdaaron @gireeshpunathil @contact-natz @BridgeAR @hooliganznat @jasnell @lpinca @addaleax @nodejs-github-bot