Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix builds #18500

Closed
wants to merge 1 commit into from
Closed

test: fix builds #18500

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 1, 2018

A former commit changed the tmpDir behavior and that broke the test from #17054 that landed shortly after.

Refs: bf6ce47

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@BridgeAR
test: fix builds
44b839c 
A former commit changed the tmpDir behavior and that broke this test.

Refs: nodejs@bf6ce47
@BridgeAR BridgeAR added test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 1, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 1, 2018
mcollina
mcollina approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and let's fast track.

BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 1, 2018
@BridgeAR
test: fix builds
4372185 
A former commit changed the tmpDir behavior and that broke this test.

PR-URL: nodejs#18500
Refs: nodejs@bf6ce47
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BridgeAR
Copy link
Member Author

BridgeAR commented Feb 1, 2018

Landed in 4372185

@BridgeAR BridgeAR closed this Feb 1, 2018
@MylesBorins
Copy link
Member

seems to rely on semver-major, setting as don't land for 9.x and below

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@BridgeAR @MayaLekova
test: fix builds
b6e1f26 
A former commit changed the tmpDir behavior and that broke this test.

PR-URL: nodejs#18500
Refs: nodejs@bf6ce47
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BridgeAR BridgeAR deleted the fix-master branch April 1, 2019 23:38
This was referenced Mar 7, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BridgeAR @MylesBorins @mcollina @nodejs-github-bot