-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: loosen condition to detect infinite loop #1857
test: loosen condition to detect infinite loop #1857
Conversation
Can that condition still be met with that kind of increase? I wonder when v8's |
984 kBytes is enough to call 100 recursive calls. I guess over 10000 loops, we should consider the My pull request decides the infinite loop when the recursive counts over I know this value is not perfect, I should loosen the value from If someone has suggestion, I will follow. |
Well, I wouldn't put too much thought into it. LGTM if it increases CI reliabilty while still catching a real infinte loop. |
LGTM, 100 depth recursion is pretty trivial for a test imo. CI for good measure, if it looks good, land it. https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/752/ |
some tests are failed, but those tests are unrelated to this PR. |
Unrelated, yes, but slightly worrying. PR still LGTM to land. Haven't seen either of these before:
cc @nodejs/crypto, any idea what's up with the last one? |
Cant read an error message out of that, but I guess we could update the test certs:
|
PR-URL: #1857 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
landed d20f018 |
Have to blame these random ARMv7 errors on the CI again, I can't reproduce this one in 100 runs on my pi2. |
PR-URL: nodejs/node#1857 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Under heavy load condition, this condition is strict that the test detects infinite loop.
So I have to loosen the condition more. currently I set the recursiveLimit is
100
.if over
100
, throw Error that detects infinite loop.this condition can detect original infinite loop problem and reduce the count of test failure like #1856 (comment)