Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: replace "magic" numbers by constants #18869

Closed
wants to merge 1 commit into from
Closed

module: replace "magic" numbers by constants #18869

wants to merge 1 commit into from

Conversation

daynin
Copy link
Contributor

@daynin daynin commented Feb 19, 2018

  • add new constants
  • replace numbers by constants
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

module

@nodejs-github-bot nodejs-github-bot added the module Issues and PRs related to the module subsystem. label Feb 19, 2018
@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 19, 2018
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13284/

@richardlau
Copy link
Member

To whoever lands this, the commit title is missing the last t in constants.

@daynin daynin changed the title module: replace "magic" numbers by constans module: replace "magic" numbers by constants Feb 21, 2018
@daynin
module: replace "magic" numbers by constants
3353f10 
- add new constants
- replace numbers by constants
@daynin
Copy link
Contributor Author

daynin commented Feb 21, 2018

@richardlau fixed

@BridgeAR
Copy link
Member

Just running a new CI before landing to make sure.

Light-CI https://ci.nodejs.org/job/node-test-commit-light/311/

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 22, 2018
@daynin @BridgeAR
module: replace "magic" numbers by constants
070a82e 
- add new constants
- replace numbers by constants

PR-URL: nodejs#18869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@BridgeAR
Copy link
Member

Landed in 070a82e 🎉

@BridgeAR BridgeAR closed this Feb 22, 2018
@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

/cc @nodejs/modules

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@daynin @BridgeAR
module: replace "magic" numbers by constants
d22a97e 
- add new constants
- replace numbers by constants

PR-URL: nodejs#18869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@daynin @MayaLekova
module: replace "magic" numbers by constants
242f911 
- add new constants
- replace numbers by constants

PR-URL: nodejs#18869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mmarchini mmarchini mmarchini approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@daynin @BridgeAR @richardlau @MylesBorins @targos @cjihrig @mmarchini @nodejs-github-bot