doc: replace to Node.js #19056
Closed
doc: replace to Node.js #19056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
i18n-api
mmarchini
approved these changes
Feb 28, 2018
mmarchini
reviewed
Feb 28, 2018
tools/icu/README.md
Outdated
| @@ -22,7 +22,7 @@ internationalization functionality. | |||
|
|
|||
| - Make sure your node workspace is clean (clean `git status`) should be | |||
| sufficient. | |||
| - Configure Node with the specific [ICU version](http://icu-project.org/download) | |||
| - Configure node with the specific [ICU version](http://icu-project.org/download) | |||
ChALkeR
reviewed
Feb 28, 2018
tools/icu/README.md
Outdated
| @@ -22,7 +22,7 @@ internationalization functionality. | |||
|
|
|||
| - Make sure your node workspace is clean (clean `git status`) should be | |||
There was a problem hiding this comment.
Is «node» here intentional? Perhaps minor rephrase would help.
There was a problem hiding this comment.
Also, «Verify the node build works:» below.
There was a problem hiding this comment.
The same applies to: Now, do a clean rebuild of node to test
|
Also, perhaps look in other files? Quick grep gives me this, for example: doc/api/deprecations.md:613:DebugContext has been removed in V8 and is not available in Node 10+.
doc/api/zlib.md:159:From `zlib/zconf.h`, modified to node.js's usage:
doc/api/documentation.md:83:and the underlying operating system. Node functions which simply wrap a syscall,
doc/api/esm.md:153:rules with only JS file extension and Node builtin modules support could
doc/api/cli.md:447:(so they can be overridden). Node will exit with an error if an option that is
doc/api/n-api.md:3490:- `[out] version`: A pointer to version information for Node itself.
doc/api/tracing.md:6:V8, Node core, and userspace code.
doc/api/tracing.md:36:Starting with Node 10.0.0, the tracing system uses the same time source as the
doc/api/domain.md:446:As of Node 8.0.0, the handlers of Promises are run inside the domain in
doc/api/fs.md:603:Prior to Node v0.12, the `ctime` held the `birthtime` on Windows
doc/api/fs.md:660: Thus for Node `< v6.3.0` use `fs` to access those constants, or
doc/guides/node-postmortem-support.md:6:provides this metadata in its builds for V8 and Node internal structures.
doc/guides/node-postmortem-support.md:16:### Node Debug Symbols
doc/guides/node-postmortem-support.md:19:constants by providing ways to inspect Node-specific structures, like
doc/guides/node-postmortem-support.md:65:sure all Node postmortem metadata are calculated correctly.
doc/guides/building-node-with-ninja.md:1:# Building Node with Ninja
doc/guides/building-node-with-ninja.md:7:To build Node with ninja, there are 3 steps that must be taken:
doc/guides/writing-tests.md:368:### Node test fixture
tools/icu/README.md:25:- Configure Node with the specific [ICU version](http://icu-project.org/download)
tools/icu/README.md:87:- Now, rebuild the Node license.
tools/icu/README.md:119:The files in this directory were written for the node.js effort.
tools/icu/README.md:128:entities within Node, although theyare being scrutinized by interested |
hiroppy
force-pushed
the
feature/replace-to-Node.js
branch
from
4de9f3c
to
5e09818
Compare
|
@ChALkeR Thanks for your advice. PTAL! |
hiroppy
force-pushed
the
feature/replace-to-Node.js
branch
from
5e09818
to
f3e98cc
Compare
lpinca
reviewed
Mar 4, 2018
tools/remark-cli/package-lock.json
Outdated
| @@ -2,7 +2,6 @@ | |||
| "name": "remark-cli", | |||
| "version": "4.0.0", | |||
| "lockfileVersion": 1, | |||
| "preserveSymlinks": "1", | |||
lpinca
approved these changes
Mar 4, 2018
|
This needs a rebase. |
hiroppy
force-pushed
the
feature/replace-to-Node.js
branch
from
f3e98cc
to
bbe8e0a
Compare
hiroppy
force-pushed
the
feature/replace-to-Node.js
branch
from
bbe8e0a
to
f8f5458
Compare
lpinca
added
the
author ready
Leko
approved these changes
Mar 5, 2018
|
Landed in 35c7238 |
Leko
pushed a commit
that referenced
this pull request
Mar 5, 2018
PR-URL: #19056 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#19056 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc
Can we replace all
node?(because I thinknodepoints to a repository probably)