Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add #include <stdio.h> to iculslocs #19150

Closed
wants to merge 1 commit into from
Closed

src: add #include <stdio.h> to iculslocs #19150

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Mar 5, 2018

iculslocs uses printf() and friends, but didn't include the header.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Mar 5, 2018
@srl295
Copy link
Member Author

srl295 commented Mar 5, 2018

configure --with-icu-source=https://ssl.icu-project.org/files/icu4c/58.2/icu4c-58_2-src.zip && make

will reproduce this (before going on to another problem)

@srl295 srl295 mentioned this pull request Mar 5, 2018
Closed
@srl295
src: #include <stdio.h>" to iculslocs
1c16d7e 
iculslocs uses stdio, but didn't include the header.
@srl295
Copy link
Member Author

srl295 commented Mar 5, 2018

fixed comment

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13521/

jasnell pushed a commit that referenced this pull request Mar 6, 2018
@srl295 @jasnell
src: #include <stdio.h>" to iculslocs
ad72142 
iculslocs uses stdio, but didn't include the header.

PR-URL: #19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@jasnell
Copy link
Member

jasnell commented Mar 6, 2018

Landed in ad72142

@jasnell jasnell closed this Mar 6, 2018
@srl295 srl295 deleted the iculslocs-printf branch March 6, 2018 16:29
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@srl295 @MylesBorins
src: #include <stdio.h>" to iculslocs
cc4c07b 
iculslocs uses stdio, but didn't include the header.

PR-URL: #19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@srl295 @MylesBorins
src: #include <stdio.h>" to iculslocs
86b6731 
iculslocs uses stdio, but didn't include the header.

PR-URL: #19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@srl295 @MylesBorins
src: #include <stdio.h>" to iculslocs
823f85f 
iculslocs uses stdio, but didn't include the header.

PR-URL: #19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@srl295 @MylesBorins
src: #include <stdio.h>" to iculslocs
4829469 
iculslocs uses stdio, but didn't include the header.

PR-URL: #19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 7, 2018
@srl295 @MylesBorins
src: #include <stdio.h>" to iculslocs
cc52dae 
iculslocs uses stdio, but didn't include the header.

PR-URL: #19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@srl295 @MayaLekova
src: #include <stdio.h>" to iculslocs
122ac91 
iculslocs uses stdio, but didn't include the header.

PR-URL: nodejs#19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
@srl295 @jasnell
src: #include <stdio.h>" to iculslocs
85d8d22 
iculslocs uses stdio, but didn't include the header.

PR-URL: nodejs#19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@srl295 @MylesBorins
src: #include <stdio.h>" to iculslocs
f33f323 
iculslocs uses stdio, but didn't include the header.

Backport-PR-URL: #22380
PR-URL: #19150
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@srl295 @gireeshpunathil @jasnell @benjamingr @cjihrig @richardlau @nodejs-github-bot