Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks,trace_events: emit perf milestone trace events #19175

Closed
wants to merge 1 commit into from
Closed

perf_hooks,trace_events: emit perf milestone trace events #19175

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 6, 2018

Emit the perf_hooks node timing milestones as trace events.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 6, 2018
@jasnell jasnell force-pushed the perf-milestone-trace-events branch from fc6d525 to 45bccc3 Compare March 12, 2018 19:33
@jasnell
Copy link
Member Author

jasnell commented Mar 12, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13645/

@jasnell
perf_hooks,trace_events: emit perf milestone trace events
40dcf2a 
Emit the perf_hooks node timing milestones as trace events.
@jasnell jasnell force-pushed the perf-milestone-trace-events branch from 45bccc3 to 40dcf2a Compare March 16, 2018 15:06
@jasnell
Copy link
Member Author

jasnell commented Mar 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13705/

jasnell added a commit that referenced this pull request Mar 16, 2018
@jasnell
perf_hooks,trace_events: emit perf milestone trace events
96cb4fb 
Emit the perf_hooks node timing milestones as trace events.

PR-URL: #19175
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell
Copy link
Member Author

jasnell commented Mar 16, 2018

Landed in 96cb4fb

@jasnell jasnell closed this Mar 16, 2018
@MylesBorins
Copy link
Member

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@AndreasMadsen AndreasMadsen Awaiting requested review from AndreasMadsen

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasnell @MylesBorins @addaleax @nodejs-github-bot