repl: remove magic mode #19187
Closed
repl: remove magic mode #19187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
added
the
semver-major
|
s/sloopy/sloppy/ in commit message and commit content. |
cjihrig
approved these changes
Mar 7, 2018
The magic mode is long deprecated and works the same as the sloppy mode. Since the sloppy mode is the default, removing the magic mode should be safe.
BridgeAR
force-pushed
the
remove-magic-mode
branch
from
270eb82
to
0c60f40
Compare
|
@mscdex thanks! Fixed. |
BridgeAR
added
the
author ready
targos
approved these changes
Mar 7, 2018
TimothyGu
approved these changes
Mar 7, 2018
thefourtheye
approved these changes
Mar 7, 2018
|
|
||
| The `repl` module's `REPL_MODE_MAGIC` constant, used for `replMode` option, has | ||
| been deprecated. Its behavior has been functionally identical to that of | ||
| been removed. Its behavior has been functionally identical to that of | ||
| `REPL_MODE_SLOPPY` since Node.js v6.0.0, when V8 5.0 was imported. Please use | ||
| `REPL_MODE_SLOPPY` instead. | ||
|
|
||
| The `NODE_REPL_MODE` environment variable is used to set the underlying |
There was a problem hiding this comment.
Is is still okay here?
There was a problem hiding this comment.
As far as I see it: yes. Because the environment variable still exists.
ChALkeR
approved these changes
Mar 7, 2018
|
Landed in 4893f70 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 11, 2018
The magic mode is long deprecated and works the same as the sloppy mode. Since the sloppy mode is the default, removing the magic mode should be safe. PR-URL: nodejs#19187 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The magic mode is long deprecated and works the same as the sloppy mode. Since the sloppy mode is the default, removing the magic mode should be safe. PR-URL: nodejs#19187 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
ChALkeR
reviewed
Sep 2, 2018
| @@ -421,6 +421,9 @@ Returns `true` if `keyword` is a valid keyword, otherwise `false`. | |||
| <!-- YAML | |||
| added: v0.1.91 | |||
| changes: | |||
| - version: REPLACEME | |||
| pr-url: https://github.com/nodejs/node/pull/REPLACEME | |||
There was a problem hiding this comment.
This was landed with a mistake.
I will make a PR with a fix (with some other minor link fixes in the docs).
tniessen
added
deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The magic mode is long deprecated and works the same as the sloppy
mode. Since the sloppy mode is the default, removing the magic mode
should be safe (passing in
undefinedor a unknown value will just usethe sloppy mode as before).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes