Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] fs: support "as" and "as+" new modes in fs.open() #19217

Closed
wants to merge 1 commit into from
Closed

[v9.x backport] fs: support "as" and "as+" new modes in fs.open() #19217

wants to merge 1 commit into from

Conversation

SirR4T
Copy link
Contributor

@SirR4T SirR4T commented Mar 8, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Original PR-URL: #18801

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v9.x labels Mar 8, 2018
@SirR4T
fs: support as and as+ flags in stringToFlags()
432b215 
PR-URL: nodejs#18801
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@SirR4T SirR4T mentioned this pull request Mar 11, 2018
Closed
4 tasks
@MylesBorins MylesBorins force-pushed the v9.x-staging branch 3 times, most recently from d457b9d to 03c321a Compare March 20, 2018 11:56
@MylesBorins
Copy link
Member

landed in 607b33c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SirR4T @MylesBorins @nodejs-github-bot