-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add TSC meeting notes 2015-06-10 #1943
doc: add TSC meeting notes 2015-06-10 #1943
Conversation
### joyent/node | ||
* Nominating new collaborators to this repository #25481 | ||
* Node should not automatically change rlimits #8704 | ||
* Rre-purpose previous joyent/node TSC meeting as LTS working group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rre
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
I'd prefer them to go in here but @Fishrock123 told me in my last one that they should be put into the iojs repo because stuff gets upstreamed from there. Also, check your markdown, you either need dot-points or double-newlines to prevent the blocks of text from becoming paragraphs (I usually run markdown docs through gfm2html before a PR to see what it looks like). |
Yes, it's probably best to land them here (in io.js) for now. You could technically land something like this into |
* Bert Belder (TSC) | ||
* Ben Noordhuis (TSC) | ||
* Julien Gilli (TSC) | ||
* Mikeal Rogers (TSC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is.. technically incorrect as of yet (i.e. Mikeal is not currently TSC yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. Also removed the TSC label from Domenic.
ee95aa4
to
00b6c10
Compare
Can I get a final LGTM from someone? @rvagg The markdown comes out just fine on my end. Can you point out where you're seeing a problem? |
* TSC needs to elect a board representative. #1697 | ||
|
||
### joyent/node | ||
* Nominating new collaborators to this repository #25481 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a blank line here?
LGTM with some nits. |
@piscisaureus I see dot-points now so no problem |
PR-URL: nodejs#1943 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
00b6c10
to
30638b1
Compare
@misterdjules suggested that this should go into the convergence repo. Would that be better?
(if we land it here then it'll end up there eventually also)