Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rename regression tests with descriptive file names (pt. 5) #19495

Closed
wants to merge 6 commits into from
Closed

test: rename regression tests with descriptive file names (pt. 5) #19495

wants to merge 6 commits into from

Conversation

ryzokuken
Copy link
Contributor

@ryzokuken ryzokuken commented Mar 20, 2018 •
edited
Loading

Rename the tests appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the tests conform to the standard test structure

Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

Checklist

  • test/parallel/test-arm-math-exp-regress-1376.js
  • test/parallel/test-buffer-regression-649.js
  • test/parallel/test-dgram-regress-4496.js
  • test/parallel/test-dns-regress-7070.js
  • test/parallel/test-http-agent-maxsockets-regress-4050.js

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 20, 2018
@ryzokuken
Copy link
Contributor Author

/cc @Trott (the last commit)

@Trott
Copy link
Member

Trott commented Mar 23, 2018

/cc @Trott (the last commit)

Last commit looks good to me. :-D

@Trott
Copy link
Member

Trott commented Mar 23, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13838/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 23, 2018
@Trott
Copy link
Member

Trott commented Mar 23, 2018

ARM failure in CI is unrelated.

Re-run node-test-binary-arm: https://ci.nodejs.org/job/node-test-binary-arm/14430/

@Trott
Copy link
Member

Trott commented Mar 23, 2018

ARM re-run is green. CI has passed. This can land.

Trott pushed a commit to Trott/io.js that referenced this pull request Mar 24, 2018
@ryzokuken @Trott
test: rename regression tests more expressively
eeb5702 
PR-URL: nodejs#19495
Refs: nodejs#19105
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Mar 24, 2018

Landed in eeb5702

@Trott Trott closed this Mar 24, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
@ryzokuken @targos
test: rename regression tests more expressively
40be64d 
PR-URL: #19495
Refs: #19105
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ryzokuken @Trott @jasnell @gireeshpunathil @nodejs-github-bot