Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] doc: linkify missing types #19498

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] doc: linkify missing types #19498

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Mar 20, 2018 •
edited

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Backport of #18444

A few types that are not actual for v8 yet are left in type-parser.js in case of future backports of relevant features (such as {os.constants.dlopen}).

@vsemozhetbyt
doc: linkify missing types
2ebd7ce 
Also, alphabetize all types in type-parser.js
and fix some nits in type formats.

PR-URL: #18444
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. v8.x labels Mar 20, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13783/

@vsemozhetbyt vsemozhetbyt mentioned this pull request Mar 21, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@vsemozhetbyt @MylesBorins
doc: linkify missing types
652abaf 
Also, alphabetize all types in type-parser.js
and fix some nits in type formats.

Backport-PR-URL: #19498
PR-URL: #18444
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Member

landed in 652abaf

@vsemozhetbyt vsemozhetbyt deleted the backport-18444-to-v8.x branch March 21, 2018 00:41
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@vsemozhetbyt @MylesBorins
doc: linkify missing types
d503427 
Also, alphabetize all types in type-parser.js
and fix some nits in type formats.

Backport-PR-URL: #19498
PR-URL: #18444
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@vsemozhetbyt @MylesBorins
doc: linkify missing types
1091dfc 
Also, alphabetize all types in type-parser.js
and fix some nits in type formats.

Backport-PR-URL: #19498
PR-URL: #18444
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsemozhetbyt @MylesBorins @nodejs-github-bot