Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: give error message if write() cb called twice #19510

Closed
wants to merge 3 commits into from
Closed

stream: give error message if write() cb called twice #19510

wants to merge 3 commits into from

Commits on Mar 21, 2018

  1. stream: give error message if write() cb called twice 

    Otherwise, this condition would result in an error that just reads
`cb is not a function`, and which additionally could have lost
stack trace context through a `process.nextTick()` call.

    $ ./node benchmark/compare.js --new ./node --old ./node-master --filter writable --runs 200 streams | Rscript benchmark/compare.R
    [00:09:36|% 100| 1/1 files | 400/400 runs | 1/1 configs]: Done
                                               confidence improvement accuracy (*)   (**)  (***)
     streams/writable-manywrites.js n=2000000                -0.28 %       ±3.51% ±4.62% ±5.92%
    @addaleax
    addaleax committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    71b7f73 View commit details
    Browse the repository at this point in the history

  2. [squash] use ERR_MULTIPLE_CALLBACK

    @addaleax
    addaleax committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    dccdccc View commit details
    Browse the repository at this point in the history

  3. [squash] fix

    @addaleax
    addaleax committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    fc665d3 View commit details
    Browse the repository at this point in the history