Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix linting issue in process.md #19542

Closed
wants to merge 1 commit into from
Closed

doc: fix linting issue in process.md #19542

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

See #19438 (comment)

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Mar 22, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 22, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Mar 22, 2018 •
edited
Loading

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/292/

@vsemozhetbyt vsemozhetbyt changed the title doc: fix lintingg issue in process.md doc: fix linting issue in process.md Mar 22, 2018
richardlau
richardlau reviewed Mar 22, 2018
View reviewed changes
doc/api/process.md Outdated
`0` if the given version matches the process version, and `1` if the given
version is greater than the release version.
* Returns: {number} `-1` if the given version is lower than the release
version,`0` if the given version matches the process version, and `1`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after comma.

@vsemozhetbyt
Copy link
Contributor Author

CI-lite 2: https://ci.nodejs.org/job/node-test-pull-request-lite/293/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2018
vsemozhetbyt added a commit that referenced this pull request Mar 22, 2018
@vsemozhetbyt
doc: fix linting issue in process.md
d1720bd 
Introduced in #19438

PR-URL: #19542
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in d1720bd

@vsemozhetbyt vsemozhetbyt deleted the doc-fix-linting-issue branch March 22, 2018 23:52
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vsemozhetbyt @Trott @richardlau @targos @tniessen @nodejs-github-bot