doc: create list for commonly edited files in PRs #19776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Apr 3, 2018
vsemozhetbyt
added
the
meta
|
@Trott This could be useful for individuals who haven't decided to create a Pull Request yet and just browsing Contributing documentation. I was one of them before I started contributing to Node.js core |
|
Last CI got aborted |
addaleax
approved these changes
Apr 3, 2018
| repository includes changes to one or more of the following: | ||
| - the C/C++ code contained in the `src` directory | ||
| - the JavaScript code contained in the `lib` directory | ||
| - the documentation in `docs/api` |
There was a problem hiding this comment.
(Pre-existing) Typo: docs → doc :)
danbev
approved these changes
Apr 4, 2018
lpinca
approved these changes
Apr 4, 2018
trivikr
added
the
author ready
jasnell
approved these changes
Apr 4, 2018
|
Landed in f02e4b9 |
trivikr
added a commit
that referenced
this pull request
Apr 6, 2018
PR-URL: #19776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 6, 2018
PR-URL: #19776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change arranges commonly edited files in PRs as a list in
pull-requests.mdThe updated document can be viewed in private branch here
Checklist