Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] doc, tools: formalize, unify and codify default values #19793

Closed
wants to merge 1 commit into from
Closed

[v9.x backport] doc, tools: formalize, unify and codify default values #19793

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Apr 4, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Backport of #19737

@vsemozhetbyt
doc,tools: formalize, unify, codify default values
022e55e 
PR-URL: #19737
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v9.x labels Apr 4, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/422/

@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 4, 2018
Closed
3 tasks
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2018
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2018
@targos
Copy link
Member

targos commented Apr 6, 2018

Thanks! Landed in 8ac4348

@targos targos closed this Apr 6, 2018
targos pushed a commit that referenced this pull request Apr 6, 2018
@vsemozhetbyt @targos
doc,tools: formalize, unify, codify default values
8ac4348 
Backport-PR-URL: #19793
PR-URL: #19737
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the backport-19737-to-v9.x branch April 6, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsemozhetbyt @targos @nodejs-github-bot