Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove link to "breaking changes" wiki #19795

Closed
wants to merge 1 commit into from
Closed

doc: remove link to "breaking changes" wiki #19795

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 4, 2018

Breaking changes wiki is not updated, so removing the paragraph as per comments by:

Checklist

@trivikr
doc: remove link to "breaking changes" wiki
674f66a 
Breaking changes wiki is not updated, so removing the paragraph
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2018
@trivikr trivikr mentioned this pull request Apr 4, 2018
Closed
2 tasks
@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 4, 2018
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/423/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2018
@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 4, 2018
@trivikr
Copy link
Member Author

trivikr commented Apr 5, 2018

Landed in 422ac61

@trivikr trivikr closed this Apr 5, 2018
trivikr added a commit that referenced this pull request Apr 5, 2018
@trivikr
doc: remove link to "breaking changes" wiki
422ac61 
Breaking changes wiki is not updated, so removing the paragraph

PR-URL: #19795
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 6, 2018
@trivikr @targos
doc: remove link to "breaking changes" wiki
0569171 
Breaking changes wiki is not updated, so removing the paragraph

PR-URL: #19795
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@trivikr trivikr deleted the trivikr-patch-5 branch April 14, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@trivikr @vsemozhetbyt @jasnell @Trott @lpinca @targos @nodejs-github-bot