Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert 19560: npm 5.8.0 #19837

Closed
wants to merge 2 commits into from
Closed

Revert 19560: npm 5.8.0 #19837

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Apr 5, 2018

Breaks CI and local tests. These are clean reverts of the commits on top of master, so let’s land this ASAP.

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 5, 2018
@addaleax addaleax mentioned this pull request Apr 5, 2018
Closed
4 tasks
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 5, 2018
@addaleax
Copy link
Member Author

addaleax commented Apr 5, 2018

Landed in 026f6b7, e37effe + rewound v9.x-staging to its previous HEAD

@addaleax addaleax closed this Apr 5, 2018
@addaleax addaleax deleted the revert-19560 branch April 5, 2018 21:00
addaleax added a commit that referenced this pull request Apr 5, 2018
@addaleax
Revert "deps: manually add 10.x support to npm"
026f6b7 
This reverts commit 55557ba.

PR-URL: #19837
Reviewed-By: Gus Caplan <me@gus.host>
addaleax added a commit that referenced this pull request Apr 5, 2018
@addaleax
Revert "deps: upgrade npm to 5.8.0"
e37effe 
This reverts commit 25a816d.

PR-URL: #19837
Reviewed-By: Gus Caplan <me@gus.host>
@MylesBorins
Copy link
Contributor

ugh... sorry about this... thought everything was working

@addaleax
Copy link
Member Author

addaleax commented Apr 5, 2018

@MylesBorins Don’t worry, these things happen :)

@MylesBorins
Copy link
Contributor

Oh I know... I break stuff all the time 🎉

Just like apologizing 😄

@SimenB SimenB mentioned this pull request Apr 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@addaleax @MylesBorins @jasnell @devsnek @targos @nodejs-github-bot