test: fix flaky http-client-timeout-agent #19856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If |
|
I guess it may make sense not to clear the timeout until the connection is fully closed and not only when the other end closes its side. |
Close the connection immediately after receiving the `end` event to avoid that the `timeout` event is fired before the connection closes gracefully. Move the test back to parallel. Fixes: nodejs#19804
santigimeno
force-pushed
the
fix_test-http-client-timeout-agent
branch
from
dd7b621
to
3f2078f
Compare
|
Updated so the test is moved back to parallel as 95dc590 moved it to sequential. |
Trott
approved these changes
Apr 8, 2018
BridgeAR
added
the
author ready
|
Landed in 5b8c62c 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 9, 2018
Close the connection immediately after receiving the `end` event to avoid that the `timeout` event is fired before the connection closes gracefully. Move the test back to parallel. PR-URL: nodejs#19856 Fixes: nodejs#19804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
Close the connection immediately after receiving the `end` event to avoid that the `timeout` event is fired before the connection closes gracefully. Move the test back to parallel. PR-URL: #19856 Fixes: #19804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
Close the connection immediately after receiving the `end` event to avoid that the `timeout` event is fired before the connection closes gracefully. Move the test back to parallel. PR-URL: nodejs#19856 Fixes: nodejs#19804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 1, 2018
Close the connection immediately after receiving the `end` event to avoid that the `timeout` event is fired before the connection closes gracefully. Move the test back to parallel. PR-URL: #19856 Fixes: #19804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
Close the connection immediately after receiving the `end` event to avoid that the `timeout` event is fired before the connection closes gracefully. Move the test back to parallel. PR-URL: #19856 Fixes: #19804 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the connection immediately after receiving the
endevent toavoid that the
timeoutevent is fired before the connection closesgracefully.
Fixes: #19804
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes